|
|
Log in / Subscribe / Register

ice: postpone service task disabling

From:  Tony Nguyen <anthony.l.nguyen-AT-intel.com>
To:  davem-AT-davemloft.net, kuba-AT-kernel.org, pabeni-AT-redhat.com, edumazet-AT-google.com, andrew+netdev-AT-lunn.ch, netdev-AT-vger.kernel.org
Subject:  [PATCH net-next 0/9][pull request] ice: postpone service task disabling
Date:  Fri, 24 Oct 2025 13:47:35 -0700
Message-ID:  <20251024204746.3092277-1-anthony.l.nguyen@intel.com>
Cc:  Tony Nguyen <anthony.l.nguyen-AT-intel.com>, przemyslaw.kitszel-AT-intel.com, jacob.e.keller-AT-intel.com, mschmidt-AT-redhat.com, poros-AT-redhat.com, horms-AT-kernel.org
Archive-link:  Article

Przemek Kitszel says:

Move service task shutdown to the very end of driver teardown procedure.
This is needed (or at least beneficial) for all unwinding functions that
talk to FW/HW via Admin Queue (so, most of top-level functions, like
ice_deinit_hw()).

Most of the patches move stuff around (I believe it makes it much easier
to review/proof when kept separate) in preparation to defer stopping the
service task to the very end of ice_remove() (and other unwinding flows).
Then last patch fixes duplicate call to ice_init_hw() (actual, but
unlikely to encounter, so -next, given the size of the changes).

First patch is not much related, only by that it was developed together
---
IWL: https://lore.kernel.org/intel-wired-lan/20250912130627.50...

The following are changes since commit f0a24b2547cfdd5ec85a131e386a2ce4ff9179cb:
  Merge branch 'net-dsa-lantiq_gswip-use-regmap-for-register-access'
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE

Przemek Kitszel (9):
  ice: enforce RTNL assumption of queue NAPI manipulation
  ice: move service task start out of ice_init_pf()
  ice: move ice_init_interrupt_scheme() prior ice_init_pf()
  ice: ice_init_pf: destroy mutexes and xarrays on memory alloc failure
  ice: move udp_tunnel_nic and misc IRQ setup into ice_init_pf()
  ice: move ice_init_pf() out of ice_init_dev()
  ice: extract ice_init_dev() from ice_init()
  ice: move ice_deinit_dev() to the end of deinit paths
  ice: remove duplicate call to ice_deinit_hw() on error paths

 .../net/ethernet/intel/ice/devlink/devlink.c  |  21 ++-
 drivers/net/ethernet/intel/ice/ice.h          |   4 +
 drivers/net/ethernet/intel/ice/ice_common.c   |   3 +
 drivers/net/ethernet/intel/ice/ice_lib.c      |   4 +-
 drivers/net/ethernet/intel/ice/ice_main.c     | 169 +++++++++---------
 5 files changed, 110 insertions(+), 91 deletions(-)

-- 
2.47.1




Copyright © 2025, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds