| From: |
| Ming Lei <ming.lei-AT-redhat.com> |
| To: |
| Jens Axboe <axboe-AT-kernel.dk>, linux-block-AT-vger.kernel.org |
| Subject: |
| [PATCH V2 00/25] ublk: add UBLK_F_BATCH_IO |
| Date: |
| Thu, 23 Oct 2025 23:32:05 +0800 |
| Message-ID: |
| <20251023153234.2548062-1-ming.lei@redhat.com> |
| Cc: |
| Uday Shankar <ushankar-AT-purestorage.com>, Caleb Sander Mateos <csander-AT-purestorage.com>, Ming Lei <ming.lei-AT-redhat.com> |
| Archive-link: |
| Article |
Hello,
This patchset adds UBLK_F_BATCH_IO feature for communicating between kernel and ublk
server in batching way:
- **Per-queue vs Per-I/O**: Commands operate on queues rather than individual I/Os
- **Batch processing**: Multiple I/Os are handled in single operation
- **Multishot commands**: Use io_uring multishot for reducing submission overhead
- **Flexible task assignment**: Any task can handle any I/O (no per-I/O daemons)
- **Better load balancing**: Tasks can adjust their workload dynamically
- **help for future optimizations**:
- blk-mq batch tags free
- support io-poll
- per-task batch for avoiding per-io lock
- fetch command priority
- ** simplify command cancel process with per-queue lock **
selftest are provided.
~5% IOPS improvement is observed(40M IOPS vs. 42M IOPS) on ublk/null:
taskset -c 0-31 ~/git/fio/t/io_uring -p0 -n16 -r 40 /dev/ublkb0
- ublk device created by builtin selftest utility:
./kublk add -t null -q 16 --auto_zc -d 512
vs.
./kublk add -t null -q 16 --auto_zc -d 512 -b
feedback & review is welcome!
V2:
- ublk_config_io_buf() vs. __ublk_fetch() order
- code style clean
- use READ_ONCE() to cache sqe data because sqe copy becomes
conditional recently
- don't use sqe->len for UBLK_U_IO_PREP_IO_CMDS &
UBLK_U_IO_COMMIT_IO_CMDS
- fix one build warning
- fix build_user_data()
- run performance analysis, and find one bug in
io_uring_cmd_buffer_select(), fix is posted already
Thanks,
Ming
Ming Lei (25):
ublk: add parameter `struct io_uring_cmd *` to
ublk_prep_auto_buf_reg()
ublk: add `union ublk_io_buf` with improved naming
ublk: refactor auto buffer register in ublk_dispatch_req()
ublk: add helper of __ublk_fetch()
ublk: define ublk_ch_batch_io_fops for the coming feature F_BATCH_IO
ublk: prepare for not tracking task context for command batch
ublk: pass const pointer to ublk_queue_is_zoned()
ublk: add new batch command UBLK_U_IO_PREP_IO_CMDS &
UBLK_U_IO_COMMIT_IO_CMDS
ublk: handle UBLK_U_IO_PREP_IO_CMDS
ublk: handle UBLK_U_IO_COMMIT_IO_CMDS
ublk: add io events fifo structure
ublk: add batch I/O dispatch infrastructure
ublk: add UBLK_U_IO_FETCH_IO_CMDS for batch I/O processing
ublk: abort requests filled in event kfifo
ublk: add new feature UBLK_F_BATCH_IO
ublk: document feature UBLK_F_BATCH_IO
selftests: ublk: fix user_data truncation for tgt_data >= 256
selftests: ublk: replace assert() with ublk_assert()
selftests: ublk: add ublk_io_buf_idx() for returning io buffer index
selftests: ublk: add batch buffer management infrastructure
selftests: ublk: handle UBLK_U_IO_PREP_IO_CMDS
selftests: ublk: handle UBLK_U_IO_COMMIT_IO_CMDS
selftests: ublk: handle UBLK_U_IO_FETCH_IO_CMDS
selftests: ublk: add --batch/-b for enabling F_BATCH_IO
selftests: ublk: support arbitrary threads/queues combination
Documentation/block/ublk.rst | 60 +-
drivers/block/ublk_drv.c | 1238 +++++++++++++++--
include/uapi/linux/ublk_cmd.h | 91 ++
tools/testing/selftests/ublk/Makefile | 7 +-
tools/testing/selftests/ublk/batch.c | 610 ++++++++
tools/testing/selftests/ublk/common.c | 2 +-
tools/testing/selftests/ublk/file_backed.c | 11 +-
tools/testing/selftests/ublk/kublk.c | 128 +-
tools/testing/selftests/ublk/kublk.h | 192 ++-
tools/testing/selftests/ublk/null.c | 18 +-
tools/testing/selftests/ublk/stripe.c | 17 +-
.../testing/selftests/ublk/test_generic_14.sh | 32 +
.../testing/selftests/ublk/test_generic_15.sh | 30 +
.../testing/selftests/ublk/test_generic_16.sh | 30 +
.../testing/selftests/ublk/test_stress_06.sh | 45 +
.../testing/selftests/ublk/test_stress_07.sh | 44 +
tools/testing/selftests/ublk/utils.h | 64 +
17 files changed, 2454 insertions(+), 165 deletions(-)
create mode 100644 tools/testing/selftests/ublk/batch.c
create mode 100755 tools/testing/selftests/ublk/test_generic_14.sh
create mode 100755 tools/testing/selftests/ublk/test_generic_15.sh
create mode 100755 tools/testing/selftests/ublk/test_generic_16.sh
create mode 100755 tools/testing/selftests/ublk/test_stress_06.sh
create mode 100755 tools/testing/selftests/ublk/test_stress_07.sh
--
2.47.0