| From: |
| Emil Tsalapatis <emil-AT-etsalapatis.com> |
| To: |
| bpf-AT-vger.kernel.org |
| Subject: |
| [PATCH v4 0/3] bpf: introduce helper for populating bpf_cpumask |
| Date: |
| Wed, 05 Mar 2025 16:12:32 -0500 |
| Message-ID: |
| <20250305211235.368399-1-emil@etsalapatis.com> |
| Cc: |
| ast-AT-kernel.org, daniel-AT-iogearbox.net, andrii-AT-kernel.org, martin.lau-AT-linux.dev, eddyz87-AT-gmail.com, yonghong.song-AT-linux.dev, tj-AT-kernel.org, memxor-AT-gmail.com, houtao-AT-huaweicloud.com, Emil Tsalapatis <emil-AT-etsalapatis.com> |
| Archive-link: |
| Article |
Some BPF programs like scx schedulers have their own internal CPU mask types,
mask types, which they must transform into struct bpf_cpumask instances
before passing them to scheduling-related kfuncs. There is currently no
way to efficiently populate the bitfield of a bpf_cpumask from BPF memory,
and programs must use multiple bpf_cpumask_[set, clear] calls to do so.
Introduce a kfunc helper to populate the bitfield of a bpf_cpumask from valid
BPF memory with a single call.
Changelog :
-----------
v3->v4
v3: https://lore.kernel.org/bpf/20250305161327.203396-1-emil@...
* Removed new tests from tools/selftests/bpf/prog_tests/cpumask.c because
they were being run twice.
Addressed feedback by Alexei Starovoitov:
* Added missing return value in function kdoc
* Added an additional patch fixing some missing kdoc fields in
kernel/bpf/cpumask.c
Addressed feedback by Tejun Heo:
* Renamed the kfunc to bpf_cpumask_populate to avoid confusion
w/ bitmap_fill()
v2->v3
v2: https://lore.kernel.org/bpf/20250305021020.1004858-1-emil...
Addressed feedback by Alexei Starovoitov:
* Added back patch descriptions dropped from v1->v2
* Elide the alignment check for archs with efficient
unaligned accesses
v1->v2
v1: https://lore.kernel.org/bpf/20250228003321.1409285-1-emil...
Addressed feedback by Hou Tao:
* Add check that the input buffer is aligned to sizeof(long)
* Adjust input buffer size check to use bitmap_size()
* Add selftest for checking the bit pattern of the bpf_cpumask
* Moved all selftests into existing files
Signed-off-by: Emil Tsalapatis (Meta) <emil@etsalapatis.com>
Emil Tsalapatis (3):
bpf: add kfunc for populating cpumask bits
selftests: bpf: add bpf_cpumask_fill selftests
bpf: fix missing kdoc string fields in cpumask.c
kernel/bpf/cpumask.c | 53 ++++++++
.../selftests/bpf/progs/cpumask_failure.c | 38 ++++++
.../selftests/bpf/progs/cpumask_success.c | 114 ++++++++++++++++++
3 files changed, 205 insertions(+)
--
2.47.1