| From: |
| Qu Wenruo <wqu-AT-suse.com> |
| To: |
| linux-btrfs-AT-vger.kernel.org |
| Subject: |
| [PATCH v2 0/8] btrfs: make subpage handling be feature full |
| Date: |
| Thu, 27 Feb 2025 16:24:38 +1030 |
| Message-ID: |
| <cover.1740635497.git.wqu@suse.com> |
| Archive-link: |
| Article |
[CHANGLOG]
v2:
- Add a new bug fix which is exposed by recent 2K block size tests on
x86_64
It's a self deadlock where the folio_end_writeback() is called with
subpage lock hold, and folio_end_writeback() will eventually call
btrfs_release_folio() and try to lock the same spin lock.
- Various grammar fixes and commit message/comments updates
- Address comments from Filipe and adds his tags
v1:
- Merge previous two patches into one
- Re-order the patches so preparation/fixes are always before feature
enablement
- Update the commit message of the first patch
So that we do not focus on the out-of-tree part, but explain why it's
not ideal in the first place (double page zeroing), and just mention
the behavior change in the future.
Since the introduction of btrfs subapge support in v5.15, there are
quite some limitations:
- No RAID56 support
Added in v5.19.
- No memory efficient scrub support
Added in v6.4.
- No block perfect compressed write support
Previously btrfs requires the dirty range to be fully page aligned, or
it will skip compression completely.
Added in v6.13.
- Various subpage related error handling fixes
Added in v6.14.
- No support to create inline data extent
- No partial uptodate page support
This is a long existing optimization supported by EXT4/XFS and
is required to pass generic/563 with subpage block size.
The last two are addressed in this patchset.
And since all features are implemented for subpage cases, the long
existing experimental warning message can be dropped, as it is already
causing a lot of concerns for users who checks the dmesg carefully.
Qu Wenruo (8):
btrfs: prevent inline data extents read from touching blocks beyond
its range
btrfs: subpage: do not hold subpage spin lock when clearing folio
writeback
btrfs: fix the qgroup data free range for inline data extents
btrfs: introduce a read path dedicated extent lock helper
btrfs: make btrfs_do_readpage() to do block-by-block read
btrfs: allow buffered write to avoid full page read if it's block
aligned
btrfs: allow inline data extents creation if block size < page size
btrfs: remove the subpage related warning message
fs/btrfs/disk-io.c | 5 -
fs/btrfs/extent_io.c | 229 +++++++++++++++++++++++++++++++++++-----
fs/btrfs/file.c | 5 +-
fs/btrfs/inode.c | 29 ++---
fs/btrfs/ordered-data.c | 23 +++-
fs/btrfs/ordered-data.h | 8 +-
fs/btrfs/subpage.c | 10 +-
7 files changed, 246 insertions(+), 63 deletions(-)
--
2.48.1