| From: |
| Akihiko Odaki <akihiko.odaki-AT-daynix.com> |
| To: |
| Jonathan Corbet <corbet-AT-lwn.net>, Willem de Bruijn <willemdebruijn.kernel-AT-gmail.com>, Jason Wang <jasowang-AT-redhat.com>, "David S. Miller" <davem-AT-davemloft.net>, Eric Dumazet <edumazet-AT-google.com>, Jakub Kicinski <kuba-AT-kernel.org>, Paolo Abeni <pabeni-AT-redhat.com>, "Michael S. Tsirkin" <mst-AT-redhat.com>, Xuan Zhuo <xuanzhuo-AT-linux.alibaba.com>, Shuah Khan <shuah-AT-kernel.org>, linux-doc-AT-vger.kernel.org, linux-kernel-AT-vger.kernel.org, netdev-AT-vger.kernel.org, kvm-AT-vger.kernel.org, virtualization-AT-lists.linux-foundation.org, linux-kselftest-AT-vger.kernel.org, Yuri Benditovich <yuri.benditovich-AT-daynix.com>, Andrew Melnychenko <andrew-AT-daynix.com>, Stephen Hemminger <stephen-AT-networkplumber.org>, gur.stavi-AT-huawei.com, devel-AT-daynix.com, Akihiko Odaki <akihiko.odaki-AT-daynix.com> |
| Subject: |
| [PATCH 0/3] tun: Unify vnet implementation and fill full vnet header |
| Date: |
| Wed, 08 Jan 2025 20:40:10 +0900 |
| Message-ID: |
| <20250108-tun-v1-0-67d784b34374@daynix.com> |
| Archive-link: |
| Article |
When I implemented virtio's hash-related features to tun/tap [1],
I found tun/tap does not fill the entire region reserved for the virtio
header, leaving some uninitialized hole in the middle of the buffer
after read()/recvmesg().
This series fills the uninitialized hole. More concretely, the
num_buffers field will be initialized with 1, and the other fields will
be inialized with 0. Setting the num_buffers field to 1 is mandated by
virtio 1.0 [2].
The change to virtio header is preceded by another change that refactors
tun and tap to unify their virtio-related code.
[1]: https://lore.kernel.org/r/20241008-rss-v5-0-f3cf68df005d@...
[2]: https://lore.kernel.org/r/20241227084256-mutt-send-email-...
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
Akihiko Odaki (3):
tun: Unify vnet implementation
tun: Pad virtio header with zero
tun: Set num_buffers for virtio 1.0
MAINTAINERS | 1 +
drivers/net/Kconfig | 5 ++
drivers/net/Makefile | 1 +
drivers/net/tap.c | 174 ++++++----------------------------------
drivers/net/tun.c | 212 ++++++++-----------------------------------------
drivers/net/tun_vnet.c | 191 ++++++++++++++++++++++++++++++++++++++++++++
drivers/net/tun_vnet.h | 24 ++++++
7 files changed, 281 insertions(+), 327 deletions(-)
---
base-commit: a32e14f8aef69b42826cf0998b068a43d486a9e9
change-id: 20241230-tun-66e10a49b0c7
Best regards,
--
Akihiko Odaki <akihiko.odaki@daynix.com>
