Spinlocks and interrupts

Imagine this scenario
Your driver holds a spinlock
The device interrupts
Your driver's interrupt handler runs
...on the same processor
...and it tries to take the lock
The processor is now hung

Spinlocks disable kernel preemption
Blocks some deadlock scenarios

But interrupts are not disabled
...by default

If interrupts are a possibility
You must disable them