LWN: Comments on "Calligra document viewer available on Android"

READ_PHONE_STATE

reedstrm — 2013-03-25T21:05:51+00:00

Latest commit fixes this, and references this thread in the bug tracker. Go go, open source! :-)

READ_PHONE_STATE

Sho — 2013-03-25T00:37:04+00:00

coffice/android/AndroidManifest.xml in the coffice branch of calligra.git, FWIW.

READ_PHONE_STATE

cesarb — 2013-03-24T22:42:27+00:00

So I installed it on a tablet (with no phone hardware), and took a look at its manifest (using ManifestViewer). I gave up finding where the original manifest xml is on the coffice source code.

It does not ask explicitly for that permission. The problem is that both minSdkVersion and targetSdkVersion are 1, meaning that the application was developed for Android 1.0. If you look at the documentation for READ_PHONE_STATE, you see that if your application was developed for an Android version older than Android 1.6, the system automatically requests that permission (among several other backward compatibility tweaks).

The fix would be to add a uses-sdk to the manifest with the correct minSdkVersion and targetSdkVersion values.

READ_PHONE_STATE

bjartur — 2013-03-24T21:54:33+00:00

I've searched for an index of the source code for full ten minutes, and yet I haven't found it. The coffice branch is public, but an online source code search engine would be terrific for casual grepping. Maybe it's time for building a YaCy draft code search.

READ_PHONE_STATE

boudewijn — 2013-03-24T19:24:32+00:00

I don't know, but I'd guess to check whether the ministro Qt libraries are already installed or not.

READ_PHONE_STATE

rfunk — 2013-03-24T19:15:18+00:00

Usually it's really for getting the device ID. Not sure why an open source app would need that, but presumably one could check the code to find out...

READ_PHONE_STATE

cesarb — 2013-03-24T18:31:25+00:00

Why does a document viewer need the READ_PHONE_STATE permission?