Some numbers and thoughts on the stable kernels
Back in March 2005, the community was discussing ways of getting important fixes out to users of mainline releases. There was talk of maintaining a separate tree containing nothing but fixes; Linus, at the time, thought that any such attempt was doomed to failure:
With such strong words of encouragement, somebody clearly had to step up to the job; that somebody turned out to be Greg Kroah-Hartman and Chris Wright. They released 2.6.11.1 on March 4, 2005 with all of three fixes. More than five years later, Greg (a.k.a. "Og") is still at it (Chris has not been active with stable updates for a while). During that time, the stable release history has looked like this:
Kernel Updates Changes Total Per release 2.6.11 12 79 7 2.6.12 6 53 9 2.6.13 5 44 9 2.6.14 7 96 14 2.6.15 7 110 16 2.6.16 62 1053 17 2.6.17 14 191 14 2.6.18 8 240 30 2.6.19 7 189 27 2.6.20 21 447 21 2.6.21 7 162 23 2.6.22 19 379 20 2.6.23 16 302 19 2.6.24 7 246 35 2.6.25 20 492 25 2.6.26 8 321 40 2.6.27 53 1553 29 2.6.28 10 613 61 2.6.29 6 383 64 2.6.30 10 419 42 2.6.31 14 826 59 2.6.32 21 1793 85 2.6.33 7 883 126 2.6.34 5 599 120 2.6.35 4 228 57
In the table above, the kernels appearing in bold are those which are still receiving stable updates as of this writing (though 2.6.27 is clearly reaching the end of the line).
A couple of conclusions immediately jump out of the table above. The first is that the number of fixes going into stable updates has clearly increased over time. From this one might conclude that our kernel releases have steadily been getting buggier. That is hard to measure, but one should bear in mind that there is another important factor at work here: the kernel developers are simply directing more fixes toward the stable tree. Far more developers are looking at patches with stable updates in mind, and suggestions that a patch should be sent in that direction are quite common. So far fewer patches fall through the cracks than they did in the early days.
There is another factor at work here as well. The initial definition of what constituted an appropriate stable tree patch was severely restrictive; if a bug did not cause a demonstrable oops or vulnerability, the fix was not considered for the stable tree. By the time we get to the 2.6.35.4 update, though, we see a wider variety of "fixes," including Acer rv620 laptop support, typo fixes, tracepoint improvements to make powertop work better, the optimistic spinning mutex scalability work, a new emu10k1 sound driver module parameter, and oprofile support for a new Intel processor. These enhancements are, arguably, all things that stable kernel users would like to have. But they definitely go beyond the original charter for this tree.
Your editor has also, recently, seen an occasional complaint about regressions finding their way into stable updates; given the volume of patches going into stable updates now, a regression every now and then should not be surprising. Regressions in the stable tree are a worrisome prospect; one can only hope that the problem does not get worse.
Another noteworthy fact is that the number of stable updates for most kernels appears to be falling slowly; the five updates for the entire 2.6.34 update history is the lowest ever, matched only by the 2.6.13 series. Even then, 2.6.34 got one more update than had been originally planned as the result of a security issue. It should seem obvious that handling this kind of patch flow for as many as four kernels simultaneously will be a lot of work; Greg, who has a few other things on his plate as well, may be running a little short on time.
Who is actually contributing patches to stable kernels? Your editor decided to do a bit of git data mining. Two kernels were chosen: 2.6.32, which is being maintained for an extended period as the result of its use in "enterprise" distributions, and 2.6.34, being the most recent kernel which has seen its final stable update. Here are the top contributors for both:
Most active stable contributors
2.6.32 Greg Kroah-Hartman 36 2.0% Daniel T Chen 32 1.8% Linus Torvalds 23 1.3% Trond Myklebust 23 1.3% Borislav Petkov 23 1.3% Ben Hutchings 21 1.2% David S. Miller 20 1.1% Theodore Ts'o 20 1.1% Tejun Heo 20 1.1% Dmitry Monakhov 20 1.1% Takashi Iwai 18 1.0% Ian Campbell 18 1.0% Jean Delvare 17 0.9% Henrique de Moraes Holschuh 17 0.9% Yan, Zheng 17 0.9% Zhao Yakui 17 0.9% Alan Stern 17 0.9% Al Viro 16 0.9% Alex Deucher 15 0.8% Dan Carpenter 15 0.8%
2.6.34 Alex Deucher 14 2.8% Joerg Roedel 14 2.8% Tejun Heo 10 2.0% Daniel T Chen 9 1.8% Neil Brown 8 1.6% Rafael J. Wysocki 8 1.6% Linus Torvalds 7 1.4% Greg Kroah-Hartman 7 1.4% Alan Stern 7 1.4% Jesse Barnes 7 1.4% Trond Myklebust 7 1.4% Ben Hutchings 7 1.4% Tilman Schmidt 7 1.4% Avi Kivity 7 1.4% Sarah Sharp 7 1.4% Ian Campbell 6 1.2% Johannes Berg 6 1.2% Jean Delvare 6 1.2% Johan Hovold 6 1.2% Will Deacon 5 1.0%
Some names on this list will be familiar. Linus never shows up on the list of top mainline contributors anymore, but he does generate a fair number of stable fixes. Other names are seen less often in the kernel context: Daniel Chen, for example, is an Ubuntu community contributor; his contributions are mostly in the welcome area of making audio devices actually work. Some of the people are in the list above because they introduced the bugs that their patches fix - appearing in that role is not necessarily an honor. But - admittedly without having done any sort of rigorous study - your editor suspects that most of the people listed above are fixing bugs introduced by others. They are performing an important and underappreciated service, turning mainline releases into kernels that the rest of the world actually wants to run.
We can also look at who is supporting this work:
Most active stable contributors by employer
2.6.32 (None) 275 15.3% Red Hat 267 14.9% Intel 194 10.8% (Unknown) 175 9.8% Novell 166 9.3% IBM 95 5.3% AMD 60 3.3% Oracle 40 2.2% Fujitsu 33 1.8% Atheros 30 1.7% Parallels 29 1.6% Citrix 27 1.5% (Academia) 26 1.5% Linux Foundation 24 1.3% NetApp 23 1.3% 23 1.3% (Consultant) 20 1.1% NEC 18 1.0% Canonical 15 0.8% Nokia 14 0.8%
2.6.34 (None) 95 18.7% Red Hat 61 12.0% (Unknown) 58 11.4% Novell 45 8.9% Intel 43 8.5% AMD 35 6.9% IBM 17 3.3% (Academia) 16 3.1% MontaVista 9 1.8% Fujitsu 9 1.8% ARM 8 1.6% Citrix 8 1.6% NetApp 7 1.4% Oracle 7 1.4% (Consultant) 7 1.4% Linux Foundation 7 1.4% 6 1.2% Nokia 6 1.2% NTT 5 1.0% VMWare 5 1.0%
These numbers quite closely match those for mainline kernel contributions, especially at the upper end. Fixing bugs is said to be boring and unglamorous work, but volunteers are still our leading source of fixes.
We did without a stable tree for the first ten 2.6.x releases, though, at this point, it's hard to imagine just how. In an ideal world, a mainline kernel release would not happen until there were no bugs left; the history of (among others) the 2.3 and 2.5 kernel development cycles shows that this approach does not work in the real world. There comes a point where the community has to create a stable release and go on to the next cycle; the stable tree allows that fork to happen without ending the flow of fixes into the released kernel.
The tables above suggest that the stable kernel process is working well,
with large numbers of fixes being directed into stable updates and with
participation from across the community. There may come a point, though,
where that community needs to revisit the standards for patches going into
stable updates. At some point, it may also become clear that the job of
maintaining these kernels is too big for one person to manage. For now,
though, the stable tree is clearly doing what it is intended to do; Greg
deserves a lot of credit for making it work so well for so long.
Index entries for this article | |
---|---|
Kernel | Development model/Stable tree |
Kernel | Releases/Stable updates |
Posted Aug 27, 2010 20:30 UTC (Fri)
by yokem_55 (subscriber, #10498)
[Link]
Posted Aug 27, 2010 20:38 UTC (Fri)
by flewellyn (subscriber, #5047)
[Link] (10 responses)
Posted Aug 28, 2010 7:17 UTC (Sat)
by Hknr (guest, #67789)
[Link] (7 responses)
Posted Aug 28, 2010 13:07 UTC (Sat)
by dmk (guest, #50141)
[Link]
Posted Aug 28, 2010 20:56 UTC (Sat)
by ncm (guest, #165)
[Link]
Posted Aug 29, 2010 2:56 UTC (Sun)
by zooko (guest, #2589)
[Link] (3 responses)
Posted Aug 29, 2010 3:44 UTC (Sun)
by corbet (editor, #1)
[Link] (2 responses)
Posted Aug 29, 2010 14:03 UTC (Sun)
by zooko (guest, #2589)
[Link]
Posted Aug 30, 2010 14:49 UTC (Mon)
by mebrown (subscriber, #7960)
[Link]
Posted Aug 29, 2010 9:36 UTC (Sun)
by erwbgy (subscriber, #4104)
[Link]
Posted Aug 27, 2010 21:21 UTC (Fri)
by spender (guest, #23067)
[Link] (10 responses)
Though volunteers beat out any other single company source of fixes, if I'm interpreting the chart correctly for 2.6.32, (100% - 15.3%) = 84.7% are coming from companies.
That said, I can imagine a good amount of the patches being submitted from company email addresses (which is what I assume the stats are generated off of) are done when the employee is "off the clock."
So my question: do we (and how do we) actually know how much of the kernel development is really a volunteer effort?
BTW, I've never seen anyone on this site call Greg a "dickhead" or anything close to it (I did a search to check, feel free to do your own). Some people, myself included, disagree with how security is conveyed and sometimes handled, but it's a gross mischaracterization to equate that with childish ad-hominem attacks that were never uttered.
I appreciate the effort Greg puts into the stable releases -- it's certainly a lot of work. As for the major "enterprise" distributions that benefit from Greg's work, do we know what else they could be doing in addition to contributing fixes to lessen the burden?
-Brad
Posted Aug 27, 2010 21:42 UTC (Fri)
by jspaleta (subscriber, #50639)
[Link]
-jef
Posted Aug 27, 2010 21:55 UTC (Fri)
by drag (guest, #31333)
[Link]
Posted Aug 27, 2010 21:59 UTC (Fri)
by corbet (editor, #1)
[Link] (3 responses)
A patch posted from a company email address is assumed to be posted with that company's blessing. Anybody who doesn't have that blessing is probably violating all kinds of rules. In short: when somebody posts a patch, in the absence of information to the contrary, we attribute it to their employer. The results are necessarily approximate, but I'm not sure how to do them better.
Posted Aug 30, 2010 8:04 UTC (Mon)
by spaetz (guest, #32870)
[Link] (1 responses)
As a side note, I have seen some research on commit patterns across projects and it was really entertaining to see some projects following strict Mo-Fri 9-5 patterns while others (also including commercial developers) committed all over the place including weekends, nights etc.
I would love to see that research across a wide range
Posted Aug 31, 2010 21:16 UTC (Tue)
by hingo (guest, #14792)
[Link]
Posted Aug 31, 2010 16:00 UTC (Tue)
by bfields (subscriber, #19510)
[Link]
Posted Aug 28, 2010 0:04 UTC (Sat)
by mpr22 (subscriber, #60784)
[Link]
Posted Aug 30, 2010 16:57 UTC (Mon)
by ironiridis (guest, #60586)
[Link]
Posted Sep 11, 2010 11:01 UTC (Sat)
by gvy (guest, #11981)
[Link] (1 responses)
https://bugzilla.kernel.org/show_bug.cgi?id=15658
Tried to forward the message with brief explanation to LKML on Aug 28 but seems like it didn't pass through (at least not to lkml.org archive).
I've re-read all of tux.org/lkml just in case, but still need advice on *how* volunteers should pass the fixes for such non-obvious issues?
Thanks anyone who might find some time to aid with this one.
Posted Aug 16, 2012 13:20 UTC (Thu)
by gvy (guest, #11981)
[Link]
Posted Aug 27, 2010 21:44 UTC (Fri)
by spender (guest, #23067)
[Link] (2 responses)
-Brad
Posted Aug 27, 2010 21:57 UTC (Fri)
by corbet (editor, #1)
[Link] (1 responses)
Posted Sep 6, 2010 9:29 UTC (Mon)
by lacostej (guest, #2760)
[Link]
I loved to see his dedication. Has someone taken his role?
Posted Aug 27, 2010 23:42 UTC (Fri)
by nicooo (guest, #69134)
[Link] (2 responses)
Posted Aug 28, 2010 1:17 UTC (Sat)
by dlang (guest, #313)
[Link] (1 responses)
it can be that someone just volunteers to maintain it after Greg finishes with it, it can be that one (or more in the case of ) major distros base their release kernel off of it, and as a result someone takes on the maintenance of the kernel after it would finish the normal process.
about the only criteria is an elimination criteria. Namely that the kernel in question must not have a disastrous amount of regressions discovered in the normal -stable period.
Posted Aug 28, 2010 15:00 UTC (Sat)
by BenHutchings (subscriber, #37955)
[Link]
Posted Aug 28, 2010 7:44 UTC (Sat)
by dambacher (subscriber, #1710)
[Link]
Posted Aug 28, 2010 19:01 UTC (Sat)
by maks (guest, #32426)
[Link] (10 responses)
First of all it is not easy to find the one that forwarded a particular patch to stable.
A quick grep in the stable queue 2.6.32 releases showed 47 contributions of mine, but I'm 100% sure not to be the top contributor of it. But that forwarded patch number is certainly a lower bound.
Please explain how you generated the stats concerning the most active contributor. Thanks.
Posted Aug 28, 2010 19:16 UTC (Sat)
by corbet (editor, #1)
[Link] (9 responses)
A quick look through 2.6.32.y shows you CC'd on a number of patches, but you are not the author of them in stable or mainline. Am I missing something?
Posted Aug 28, 2010 19:46 UTC (Sat)
by josh (subscriber, #17465)
[Link] (7 responses)
On that note, thanks to maks and the other Debian kernel maintainers for doing an awesome job. :)
Posted Aug 28, 2010 19:57 UTC (Sat)
by corbet (editor, #1)
[Link] (3 responses)
Posted Aug 29, 2010 0:46 UTC (Sun)
by hmh (subscriber, #3838)
[Link] (2 responses)
Also, when there is no "spotted-by:" but there is a "cc: stable", it likely means that the patch author noticed it should go into stable.
That said, I think "stable-proposal-by" would be a better tag.
Posted Aug 29, 2010 14:44 UTC (Sun)
by eduard.munteanu (guest, #66641)
[Link] (1 responses)
This...
Signed-off-by: <original author>
Could turn into this...
Signed-off-by: <original author>
Possibly with some variation, such as whether or not you keep the maintainer in the Signed-off-by chain.
Posted Aug 30, 2010 22:32 UTC (Mon)
by bfields (subscriber, #19510)
[Link]
Yeah. Here's a previous discussion, where Linus says:
Posted Aug 28, 2010 23:44 UTC (Sat)
by ncm (guest, #165)
[Link] (1 responses)
Posted Aug 29, 2010 13:00 UTC (Sun)
by maks (guest, #32426)
[Link]
Hope that helps otherwise please ask on debian-kernel mailinglist.
Posted Aug 29, 2010 13:05 UTC (Sun)
by maks (guest, #32426)
[Link]
As one can see on aboves authorship table Ben Hutchings is doing an incredible great job in the last year.
Posted Aug 29, 2010 12:56 UTC (Sun)
by maks (guest, #32426)
[Link]
Got confused by the title of the table "Most active stable contributors" and thought it was about the ones that notify stable. Could then be renamed to "Most active stable authors".
Indeed there is currently no possibility to easily see who forwarded the patches to gregkh.
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
He's one of the few kernel guys whose messages go straight
to /dev/null in my LKML filter. This also lowers the
traffic by a considerable amount as you no longer see
his endless "stable preview" threads.
unpolite, unrespectful, uninformative and subjective
<quote>Please try to be polite, respectful, and informative, and to provide a useful subject line.</quote>
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
It's in the My Account area.
Filtering
Filtering
Filtering ENABLED
Well, that may be true, but he is definitely a more useful dickhead than you are.
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Who is ever really off the clock in this field?
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
I've been playing with the idea of producing similar stats for MySQL/MariaDB development, to benchmark it against Linux and other similar projects. This is an excellent idea to add to the analysis! Thanks.
Some numbers and thoughts on the stable kernels
If I read lwn at work, am I shirking? If I read it after hours, am I bringing my work home with me? Help!
Some numbers and thoughts on the stable kernels
People almost never call anyone a dickhead on LWN :)
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Well, I tried to get the patch for deadlock issue our folks have nailed down and fixed (it was rather worked around upstream) along at least into 2.6.27.y since this summer, and so far rather failed to bring attention to the issue:
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Is there some context in which Adrian should have been mentioned? I didn't talk about 2.6.16, really...and he hasn't really been present in the kernel community for a while now.
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
1. Distributions need to let him know which stable releases they want to keep going.
2. They need to help in gathering updates, and potentially to take over maintenance.
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Secondly most in all times this random person gets gets showed into the Cc: of the stable patch and thus is not distinguisable from usual Cc's that happen to be listed there.
I simply look at the author of each patch as is shown in the stable git repository.
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
I agree it would be nice to credit people who do that kind of work. There is really no information trail at the moment which would make that possible, though. Maybe we need a Spotted-by: tag to mark patches directed to stable by people other than their author?
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
Signed-off-by: <maintainer>
Signed-off-by: Linus Torvalds
Signed-off-by: <spotter>
Signed-off-by: Greg KH
Some numbers and thoughts on the stable kernels
Hm, a simple "Signed-off-by:" should suffice.
So when you save a patch from oblivion by passing it on to the right person, and get it submitted when it was originally dropped by some
reason, you're actually doing a fundamentally important job. Maybe it's
just one small piece of the puzzle, but hey, you'd only get one small line
in the changeset, so the credit (or blame ;) really is appropriate.
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels
apt-get install linux-image-2.6.35-trunk-amd64 -t experimental
Some numbers and thoughts on the stable kernels
Some numbers and thoughts on the stable kernels