|| ||Thomas Gleixner <firstname.lastname@example.org> |
|| ||LKML <email@example.com> |
|| ||[RFC patch 0/8] genirq: Support for irq domains in generic irq chip |
|| ||Fri, 03 May 2013 21:50:43 -0000|
|| ||Sebastian Hesselbarth <firstname.lastname@example.org>,
Russell King - ARM Linux <email@example.com>,
Grant Likely <firstname.lastname@example.org>,
Rob Herring <email@example.com>,
Rob Landley <firstname.lastname@example.org>, Arnd Bergmann <email@example.com>,
Jason Cooper <firstname.lastname@example.org>,
Andrew Lunn <email@example.com>,
Jason Gunthorpe <firstname.lastname@example.org>,
Thomas Petazzoni <email@example.com>,
Gregory Clement <firstname.lastname@example.org>,
Ezequiel Garcia <email@example.com>,
Maxime Ripard <firstname.lastname@example.org>,
Jean-Francois Moine <email@example.com>,
Gerlando Falauto <firstname.lastname@example.org>,
|| ||Article, Thread
The ongoing device tree support for ARM is creating new irq chip
drivers in drivers/irqchip/ in a frenzy. Quite some of them are
ripping out the generic irq chip implementation from arch/arm/* and
just creating the same mess of duplicated code again, which was
cleaned up with the generic irq chip implementation with a lot of
I already prodded a few people in reviews to tackle that issue with no
outcome. Even more sigh!
Poor Sebastian triggered me into rant mode, but he ad hoc
volunteered to give it a try. YAY!
Though he asked for a bit of kickstart help. So I squeezed out a few
spare cycles and implemented the basics as far as I think that they
The following series contains the missing bits and pieces including a
somehow forgotten and now slightly modified series from Gerlando
adding support for irq chips which need separate mask caches for
different chip (control flow) types.
At the moment this supports only linear irq domains, but it could be
extended to other types as well if the need arises. Though the ARM
chips are pretty much all about linear domains AFAICT.
It also lacks support for removing an irq domain at the moment, but
that should be rather trivial to fix.
The last patch in the series is a blind conversion of the irq-sun4i
irq chip driver, completely untested and not even compiled. I just
added it for demonstration purposes. As Russell expected, there is a
lot of consolidation potential. The changelog of that patch is:
1 file changed, 29 insertions(+), 71 deletions(-)
The preparing series has
4 files changed, 294 insertions(+), 50 deletions(-)
So for removing 42 lines in a single driver the core grows 244 lines
including header changes and comments. Convert 6 drivers and we are
more than even because we get the benefit of sharing and therefor
exposing the same code to broader testing and utilization.
We have already 11 of those candidates in drivers/irqchips and new
ones are knocking on the door.
There might be even more consolidation potential, but I leave that to the
DT/irq domain experts.
WARNING: It's compile tested only. So if you find bugs you can keep
them and fix them yourself :)
drivers/irqchip/irq-sun4i.c | 100 ++++-----------
include/linux/irq.h | 45 ++++++-
include/linux/irqdomain.h | 12 +
kernel/irq/generic-chip.c | 281 +++++++++++++++++++++++++++++++++++++-------
kernel/irq/irqdomain.c | 6
5 files changed, 323 insertions(+), 121 deletions(-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to email@example.com
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/