|| ||ebiederm-AT-xmission.com (Eric W. Biederman) |
|| ||Tejun Heo <tj-AT-kernel.org> |
|| ||Re: [PATCHSET] idr: implement idr_alloc() and convert existing users |
|| ||Sun, 03 Feb 2013 05:41:16 -0800|
|| ||akpm-AT-linux-foundation.org, linux-kernel-AT-vger.kernel.org,
skinsbursky-AT-parallels.com, jmorris-AT-namei.org, axboe-AT-kernel.dk|
|| ||Article, Thread
Tejun Heo <email@example.com> writes:
So my first response after looking at the ipc patch is ick.
Why the deep percpu magic?
Why don't associate idr_preload with an idr structure.
When reading code with idr_preload I get this deep down creepy feeling.
What is this magic that is going on?
Can't we just put the preload list_head into struct idr make
idr_preload and idr_preload_end take an idr argument?
Maybe we can have a special structure we put on the stack that has
the list_head and the preload state instead.
The way this works just weirds me out and I really really don't like it.
I would rather continue to use the existing functions as problematic as
they are as I don't need a course in deep magic to make sense of them.
> id = idr_alloc(idr, ptr, lower_limit, upper_limit, GFP_NOWAIT);
> if (id < 0)
> return id;
to post comments)