LWN.net Logo

Humphrey: On Code Review

Humphrey: On Code Review

Posted Jan 21, 2013 20:02 UTC (Mon) by JoeBuck (subscriber, #2330)
In reply to: Humphrey: On Code Review by dps
Parent article: Humphrey: On Code Review

Perhaps I'm missing something, but isn't that the kind of thing code review is supposed to catch: reviewers reject the original code and require either that the new code be fixed to follow the standard error convention, or if the third-party code can't be changed, to always call it via a wrapper so the translation of error codes happens in one place?


(Log in to post comments)

Copyright © 2013, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds