Quotes of the week: FALLOC_FL_NO_HIDE_STALE edition
[Posted December 11, 2012 by corbet]
If (maintainer thinks their patch is right) {
patch doesn't need review
} else {
/* maintainer thinks the patch is wrong. */
/* XXX: why would you think your own patch is wrong? */
patch needs review
}
—
Dave Chinner
Review is part of the way we work as a community and we should
figure out how to fix our review process so that we can have
meaningful results from the review or we lose confidence in the
process and it makes it much harder to get reviewers to spend time
reviewing when their reviews are ultimately ignored.
—
Ric Wheeler
Anybody who claims that our "process" requires that things like
that go on the mailing list and pass long reviews and discussions
IS JUST LYING.
Because it's not true. We discuss big features, and we want code
review, yes, but the fact is, most small obvious patches do *not*
get reviewed, they just get fixed. You all know that, why the hell
are you suddenly claiming that this is so magically different?
—
Linus Torvalds
This is why this discussion reminds me so much of the wakelocks
discussion, and why I've made the same decision the Android folks
made, except they wasted far more time and got far more frustrated
--- I'll just keep the damned thing as a out-of-tree patch, until
there are enough other people willing to say that they need and are
using this patch because their workloads and use cases need it. It
will save me a whole lot of time.
—
Ted Ts'o
(
Log in to post comments)