LWN.net Logo

doesn't work :(

doesn't work :(

Posted Dec 5, 2012 11:09 UTC (Wed) by HelloWorld (guest, #56129)
In reply to: I've modified "sweeten" per your suggestion by david.a.wheeler
Parent article: GNU Guile 2.0.7 released

Hey David, I just checked out sweeten from the git repository on sourceforge, and I can't see the change.

$ ./sweeten <<< '(defun foo (bar baz) ...)'
defun foo bar(baz) ...
The first parameter is still outside the parenthesis :(


(Log in to post comments)

It works - you need to check out the develop branch

Posted Dec 5, 2012 19:42 UTC (Wed) by david.a.wheeler (guest, #72896) [Link]

It works, you just need to check out the *develop* branch in the git repo, not the *master* branch.

The master branch represents the currently-released version. Our workflow is described in http://sourceforge.net/p/readable/wiki/Workflow/ and is based on Vincent Driessen's "successful git branching model" workflow.

I get:

$ ./sweeten <<< '(defun foo (bar baz) ...)'
defun foo (bar baz)
  bar baz
  ...

Which I believe is what you wanted.

It works - you need to check out the develop branch

Posted Dec 5, 2012 19:54 UTC (Wed) by HelloWorld (guest, #56129) [Link]

Hi, OK, I got the master branch now.
$ ./sweeten <<< '(defun foo (bar baz) ...)'
defun foo (bar baz)
  bar baz
  ...
Yes, that is what I get too, but... how does it make sense? The function arguments are there twice now. I'm not much of a Lisp person, but shouldn't it be either
defun foo (bar baz)
  ...
or
defun foo
  bar baz
  ...
?

Whups! Bug fixed

Posted Dec 5, 2012 21:34 UTC (Wed) by david.a.wheeler (guest, #72896) [Link]

how does it make sense?

The technical answer is, "because I screwed up" :-). A copy-and-paste error on my part, sorry. I was so focused on getting the first line right that I didn't pay attention to the second line once I got the first line right. I guess I'm still human.

I've fixed the bug and posted it on the git repo. I knew there was a reason to have a development branch :-).

Seems to work

Posted Dec 5, 2012 21:38 UTC (Wed) by HelloWorld (guest, #56129) [Link]

Good job :)

Copyright © 2013, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds