|| ||"Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA-AT-public.gmane.org> |
|| ||Rui Xiang <leo.ruixiang-Re5JQEeQqe8AvxtiuMwx3w-AT-public.gmane.org> |
|| ||Re: [PATCH RFC 3/5] printk: modify printk interface for
|| ||Wed, 21 Nov 2012 17:49:17 +0000|
"Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w-AT-public.gmane.org>, netdev-u79uwXL29TY76Z2rM5mHXA-AT-public.gmane.org|
|| ||Article, Thread
I notice that you haven't made any changes to the struct cont. I
suspect this means that to-be-continued msgs from one ns can be
erroneously mixed with another ns.
You said you don't mind putting the syslogns into the userns. If
there's no reason not to do that, then we should do so as it will
remove a bunch of code (plus the use of a new CLONE flag) from your
patch, and the new syslog(NEW_NS) command from mine.
Now IMO the ideal place for syslog_ns would be in the devices ns,
but that does not yet exist, and may never. The bonus to that would
be that the consoles sort of belong there. I avoid this by not
having consoles in child syslog namespaces. You put the console in
the ns. I haven't looked closely enough to see if what you do is
ok (will do so soon).
WOuld you mind looking through my patch to see if it suffices for
your needs? Where it does not, patches would be greatly appreciated
if simple enough.
Note I'm not at all wedded to my patchset. I'm happy to go with
something else entirely. My set was just a proof of concept.
to post comments)