LWN.net Logo

Quotes of the week

Quotes of the week

Posted Aug 24, 2012 22:06 UTC (Fri) by daglwn (subscriber, #65432)
Parent article: Quotes of the week

> If at all possible, once the author makes the changes you have requested,
> r+ the patch. Your feedback can be thought of as a contract with the
> patch author: you do these things and the patch is good enough. Don’t
> change the terms of the contract. File a followup bug, if need be.

Yes!

Yes, yes, yes! I cannot overemphasize how frustrating it is to have the goalposts moved after working days or weeks on a patch. It is almost the best way to drive away contributions from your project.


(Log in to post comments)

Quotes of the week

Posted Aug 27, 2012 22:41 UTC (Mon) by mathstuf (subscriber, #69389) [Link]

At least a comment to the effect of "I got this far and saw these major problems; I'll go over things with a fine-toothed comb after that stuff is fixed". Knowing that there *are* further goalposts would be enough, IMO.

Copyright © 2013, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds