Posted Aug 24, 2012 22:06 UTC (Fri) by daglwn (subscriber, #65432)
Parent article: Quotes of the week
> If at all possible, once the author makes the changes you have requested,
> r+ the patch. Your feedback can be thought of as a contract with the
> patch author: you do these things and the patch is good enough. Don’t
> change the terms of the contract. File a followup bug, if need be.
Yes, yes, yes! I cannot overemphasize how frustrating it is to have the goalposts moved after working days or weeks on a patch. It is almost the best way to drive away contributions from your project.