|| ||Andrew Morton <akpm-AT-linux-foundation.org> |
|| ||Robin Holt <holt-AT-sgi.com> |
|| ||Re: [patch] sgi-xp: nested calls to spin_lock_irqsave() |
|| ||Thu, 28 Jun 2012 15:03:42 -0700|
|| ||Dan Carpenter <dan.carpenter-AT-oracle.com>,
Jack Steiner <steiner-AT-sgi.com>|
|| ||Article, Thread
On Wed, 27 Jun 2012 08:51:55 -0500
Robin Holt <email@example.com> wrote:
> The code here has a nested spin_lock_irqsave(). It's not needed since
> IRQs are already disabled and it causes a problem because it means that
> IRQs won't be enabled again at the end. The second call to
> spin_lock_irqsave() will overwrite the value of irq_flags and we can't
> restore the proper settings.
Please find large crayon and write on forehead "when fixing a bug,
be sure to describe the end-user impact of that bug".
Then others will have a chance of deciding whether the fix should be
> Signed-off-by: Dan Carpenter <firstname.lastname@example.org>
> Signed-off-by: Robin Holt <email@example.com>
I'm wondering if there should have been a Reported-by:dan in there.
He's like that.
to post comments)