| |||||||||||||
Still emailing patches?Still emailing patches?Posted Jun 9, 2012 20:09 UTC (Sat) by marcH (subscriber, #57642)In reply to: Still emailing patches? by jengelh Parent article: LinuxCon Japan: Making kernel developers less grumpy
> > If the first time your code is being reviewed is a PULL request, you're doing it wrong.
> I do not think so. A pull request, in properly-organized circles, always involves an implicit request for review
Should be called a fetch request.
(Log in to post comments)
Still emailing patches? Posted Jun 10, 2012 18:29 UTC (Sun) by mathstuf (subscriber, #69389) [Link]
Eh, that doesn't mesh well with git's verbiage. I don't really care if all someone does is fetch my code from my repository. What I am actually asking for is someone to fetch and integrate my code into their tree. This is done with pull usually. Other terms I can accept: merge request, patch request, patch review, and branch review. I don't think 'fetch' really works here though.
Still emailing patches? Posted Jun 11, 2012 6:56 UTC (Mon) by marcH (subscriber, #57642) [Link]
> I don't really care if all someone does is fetch my code from my repository.
So, if I ask you to fetch my (not ready yet) code you will do it just to waste bandwidth?
|
|||||||||||||