LWN.net Logo

Still emailing patches?

Still emailing patches?

Posted Jun 7, 2012 18:44 UTC (Thu) by jengelh (subscriber, #33263)
In reply to: Still emailing patches? by iabervon
Parent article: LinuxCon Japan: Making kernel developers less grumpy

>pull requests [...] don't provide a useful structure for feedback on the code level; you really want the patch as the context for the discussion

Pull requests without patches may work in some circles. However, where trees grow by the gardening rules of David Miller — and the networking tree has been named as an organized citizen by LWN before, sort of —, pulls better had patches alongside.

Do `git send-email --compose ...`, and while in the editor, run-and-paste the output of `git request-pull ...`.


(Log in to post comments)

Copyright © 2013, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds