Not logged in
Log in now
Create an account
Subscribe to LWN
An "enum" for Python 3
An unexpected perf feature
LWN.net Weekly Edition for May 16, 2013
A look at the PyPy 2.0 release
PostgreSQL 9.3 beta: Federated databases and more
Still emailing patches?
Posted Jun 7, 2012 13:04 UTC (Thu) by jengelh (subscriber, #33263)
I do not think so. A pull request, in properly-organized circles, always involves an implicit request for review — which is why you can see "this is not ready yet"-type of warnings when the pull is not really meant as a pull, but as a review only that just happens to look like a pull request; git-request-pull(1) just makes for a short statistical overview.
Posted Jun 7, 2012 16:03 UTC (Thu) by iabervon (subscriber, #722)
Posted Jun 7, 2012 17:01 UTC (Thu) by epa (subscriber, #39769)
A pull request makes more sense, in a way, since if you want to view the code differences in a different format you can do so easily.
Posted Jun 7, 2012 17:33 UTC (Thu) by iabervon (subscriber, #722)
Of course, this is only relevant if the project communication is mailing-list-based, and particularly if it's got policies which imply that participants must have heavy-duty email-handling techniques; that's not all (or even most) projects, but it is the kernel.
Posted Jun 9, 2012 20:29 UTC (Sat) by marcH (subscriber, #57642)
Posted Jun 7, 2012 18:44 UTC (Thu) by jengelh (subscriber, #33263)
Pull requests without patches may work in some circles. However, where trees grow by the gardening rules of David Miller — and the networking tree has been named as an organized citizen by LWN before, sort of —, pulls better had patches alongside.
Do `git send-email --compose ...`, and while in the editor, run-and-paste the output of `git request-pull ...`.
Posted Jun 9, 2012 20:09 UTC (Sat) by marcH (subscriber, #57642)
> I do not think so. A pull request, in properly-organized circles, always involves an implicit request for review
Should be called a fetch request.
Posted Jun 10, 2012 18:29 UTC (Sun) by mathstuf (subscriber, #69389)
Posted Jun 11, 2012 6:56 UTC (Mon) by marcH (subscriber, #57642)
So, if I ask you to fetch my (not ready yet) code you will do it just to waste bandwidth?
Copyright © 2013, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds