|| ||Linus Torvalds <torvalds-AT-linux-foundation.org> |
|| ||Joe Perches <joe-AT-perches.com> |
|| ||Re: [PATCH] printk: support structured and multi-facility log messages |
|| ||Thu, 5 Apr 2012 18:31:04 -0700|
|| ||Kay Sievers <kay-AT-vrfy.org>, linux-kernel-AT-vger.kernel.org,
Greg Kroah-Hartmann <greg-AT-kroah.com>|
|| ||Article, Thread
On Thu, Apr 5, 2012 at 6:12 PM, Joe Perches <firstname.lastname@example.org> wrote:
> I still think this should be 3 patches not 1.
I do agree that that would be lovely. That patch is really hard to
read, and it would be helpful if some of it was split up a bit. For
example, separating out the "move log buffer to be packetized"
(without actually doing the new things) from for the "introduce new
interfaces" would be quite nice.
In fact, I think I could merge something that does the packetization
early, if it is fairly obvious that it doesn't do anything else. Just
making the dmesg ASCII timestamp be something that is a "read buffer"
time thing rather than "generate printk" time thing would be nice, and
I think the sequence numbers can be useful even with all the old
So if somebody wants to help with things like that, and try to turn
this into a more gradual thing, I think we could merge at least some
initial parts of this patch even for 3.4.
PS looking some more at the patch, it has some more obvious insanities
in it. Doing "SUBSYSTEM=(NULL subsystem)" is clearly just insane. If
you don't have a subsystem, you shouldn't have that key/value pair -
saying you have a NULL subsystem is just crazy. Details like this
would possibly stand out a bit more if it wasn't one big patch.
to post comments)