Weekly edition	Kernel	Security	Distributions	Contact Us	Search
Archives	Calendar	Subscribe	Write for LWN	LWN.net FAQ	Sponsors

A turning point for GNU libc

Posted Apr 3, 2012 0:20 UTC (Tue) by gdt (subscriber, #6284)
In reply to: A turning point for GNU libc by arjan
Parent article: A turning point for GNU libc

Write the trailing 0 character which strlcpy() should have done:

char dst[DST_SIZE];

strlcpy(dst, src, DST_SIZE);
dst[DST_SIZE-1] = '\0';

(Log in to post comments)

A turning point for GNU libc

Posted Apr 3, 2012 6:58 UTC (Tue) by smurf (subscriber, #17840) [Link]

That code doesn't make any sense whatsoever. strlcpy does write a trailing zero.
What he wants is essentially a string copy which, when the buffer is too small, zeroes the buffer's FIRST byte, not its last.

A turning point for GNU libc

Posted Apr 9, 2012 11:04 UTC (Mon) by gdt (subscriber, #6284) [Link]

You're right, I was thinking of strncpy().