LWN.net Logo

Re: [PATCH] checkpatch: Warn on code with 6+ tab indentation

From:  Tony Luck <tony.luck-AT-intel.com>
To:  Joe Perches <joe-AT-perches.com>
Subject:  Re: [PATCH] checkpatch: Warn on code with 6+ tab indentation
Date:  Fri, 3 Feb 2012 20:45:31 -0800
Message-ID:  <CA+8MBbLeWJ1ifBcJfj1MEO15tAuMBYHvu9kk7NNuUivOsNCWxw@mail.gmail.com>
Cc:  Linus Torvalds <torvalds-AT-linux-foundation.org>, Andy Whitcroft <apw-AT-shadowen.org>, Ingo Molnar <mingo-AT-elte.hu>, Andrew Morton <akpm-AT-linux-foundation.org>, Cyrill Gorcunov <gorcunov-AT-openvz.org>, linux-kernel-AT-vger.kernel.org, Pavel Emelyanov <xemul-AT-parallels.com>, Serge Hallyn <serge.hallyn-AT-canonical.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu-AT-jp.fujitsu.com>, Kees Cook <keescook-AT-chromium.org>, Tejun Heo <tj-AT-kernel.org>, Andrew Vagin <avagin-AT-openvz.org>, "Eric W. Biederman" <ebiederm-AT-xmission.com>, Alexey Dobriyan <adobriyan-AT-gmail.com>, Andi Kleen <andi-AT-firstfloor.org>, KOSAKI Motohiro <kosaki.motohiro-AT-gmail.com>, "H. Peter Anvin" <hpa-AT-zytor.com>, Thomas Gleixner <tglx-AT-linutronix.de>, Glauber Costa <glommer-AT-parallels.com>, Matt Helsley <matthltc-AT-us.ibm.com>, Pekka Enberg <penberg-AT-kernel.org>, Eric Dumazet <eric.dumazet-AT-gmail.com>, Vasiliy Kulikov <segoon-AT-openwall.com>,
Archive-link:  Article, Thread

On Fri, Feb 3, 2012 at 3:20 PM, Joe Perches <joe@perches.com> wrote:
> Another might be to limit variable name length to something
> shorter than say 10 characters.

10? We have a few cases of variables over 100 (not sure how you are supposed
to use them with an 80 character max line length). Current longest is:

eOpenLogicalChannelAck_reverseLogicalChannelParameters_multiplexParameters_h2250LogicalChannelParameters

at 104 characters.

-Tony


(Log in to post comments)

Copyright © 2012, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds