> So, if a driver contains code like:
> writel(devp->regs, 0xf4ee0815);
> it is missing something important.
One could argue that one important thing this code fragment is missing is GPL compliance.
> The source code for a work means the preferred form of the work for
> making modifications to it.
You cannot make sensible modifications to the above. You need it to be combined with documentation. So if the datasheet were included with the source code it might be OK. But without the data sheet ... it seems little different to binary firmware blobs.
(I've just been looking at init_lb035q02_panel() in