LWN.net Logo

Quote of the week

Quote of the week

Posted Nov 3, 2011 17:00 UTC (Thu) by felixfix (subscriber, #242)
In reply to: Quote of the week by nix
Parent article: Quote of the week

I haven't checked all the comments, and I haven't done kernel work of any kind for years, but the few I looked at seemed reasonable. You don't want a README of FAQ for comments, you want a guide that helps those who are willing to help themselves. I have found that if comments expound too much on everything, readers think they know more than they do and make intemperate changes, and you have to go in afterwards and clean up. I'd rather comments seemed mysterious enough that drive by programmers came to me for enlightenment or studied the matter more.


(Log in to post comments)

Quote of the week

Posted Nov 3, 2011 21:52 UTC (Thu) by nix (subscriber, #2304) [Link]

Yeah, on rereading I think I'm overreacting. It's overspill from the terrifyingly uncommented code I'm handling at work I think :) (why yes, of *course* the right number of comments in a compiler's entire code generator is zero.)

Quote of the week

Posted Nov 5, 2011 2:05 UTC (Sat) by pflugstad (subscriber, #224) [Link]

Frankly, I'd rather have zero comments vs the 150+ lines of inane comments like:

/*
* Purpose
* loop counter
*
*/
int i;

in EVERY function...

And, just to make it clear the state of this code, this user space application has 51,000+ mutexes in it. Two threads. Yes, that is NOT a typo - 51,000.

Quote of the week

Posted Nov 6, 2011 1:01 UTC (Sun) by valyala (guest, #41196) [Link]

A mutex per hash table bucket?

Quote of the week

Posted Nov 6, 2011 4:16 UTC (Sun) by pflugstad (subscriber, #224) [Link]

More or less, but way more messy.

Pete

Copyright © 2013, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds