|| ||Rafał Miłecki <zajec5-AT-gmail.com> |
|| ||Dan Carpenter <error27-AT-gmail.com> |
|| ||Re: [PATCH v2] Move brcm80211 to mainline |
|| ||Sat, 27 Aug 2011 16:59:36 +0200|
|| ||"devel-AT-linuxdriverproject.org" <devel-AT-linuxdriverproject.org>,
|| ||Article, Thread
W dniu 27 sierpnia 2011 16:35 u?ytkownik Dan Carpenter
> On Thu, Aug 25, 2011 at 10:55:26PM +0200, Rafa? Mi?ecki wrote:
>> 2011/8/25 Henry Ptasinski <firstname.lastname@example.org>:
>> > With the latest series of cleanup patches merged in by Greg KH, I'd like to
>> > once again propose moving brcm80211 out of staging and into mainline.
>> Henry: a simple question, please explain it to me, what brcmsmac does
>> provide that b43 doesn't?
> Wow. Why are we only having this discussion now? Somewhere along
> the line, there has been a massive communications failure. What
> happened here? Henry, did you know about the b43 driver? Can
> someone explain what's going on?
[Don't care to read that if you know b43&brcm80211 history]
You've to understand the architecture of Broadcom's cards first. It
less or more (less) like that:
Card -> Bus -> Chipset -> PHY & radio
The biggest part of the code is to support PHY and radio. There are of
course different types of both. It does not matter if PHY is located
on SSB bus or BCMA bus, you program it almost the same way.
brcm80211 (brcmsmac) supports PHY type "N", but it has support for
BCMA bus only.
When brcm80211 appeared, b43 supported PHY type "N", but it was
limited to SSB bus only.
I've added support for BCMA to b43 and this automatically enabled
support for new cards that were based on PHY type "N". Recently I've
added support for PHY type "HT" and now I'm working on LCN.
The code duplication between b43 and brcmsmac was acceptable when b43
didn't support BCMA. brcm80211 was really needed then because we
needed support for cards using BCMA. Now when b43 supports bcma it
sounds less interesting. brcm80211 duplicates a lot of general code,
PHY type N support code, but at the same time it doesn't support all
the N-PHY devices (there ssb based).
devel mailing list
to post comments)