Re: [PATCH v2] kernel: escape non-ASCII and control characters in
printk()
[Posted June 28, 2011 by jake]
| From: |
| Vasiliy Kulikov <segoon-AT-openwall.com> |
| To: |
| Ingo Molnar <mingo-AT-elte.hu> |
| Subject: |
| Re: [PATCH v2] kernel: escape non-ASCII and control characters in
printk() |
| Date: |
| Sun, 26 Jun 2011 23:06:22 +0400 |
| Message-ID: |
| <20110626190622.GB4217@albatros> |
| Cc: |
| Andrew Morton <akpm-AT-linux-foundation.org>,
James Morris <jmorris-AT-namei.org>,
Namhyung Kim <namhyung-AT-gmail.com>,
Greg Kroah-Hartman <gregkh-AT-suse.de>,
kernel-hardening-AT-lists.openwall.com, linux-kernel-AT-vger.kernel.org,
Alan Cox <alan-AT-lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds-AT-linux-foundation.org> |
| Archive‑link: | |
Article |
On Sun, Jun 26, 2011 at 20:26 +0200, Ingo Molnar wrote:
> > > Also, i think it would be better to make this opt-out, i.e.
> > > exclude the handful of control characters that are harmful (such
> > > as backline and console escape), instead of trying to include the
> > > known-useful ones.
> >
> > Do you see any issue with the check above?
>
> There were clear problems with the first version you posted and
> that's enough proof to request the exclusion of known-dangerous
> characters instead of including known-useful characters.
It doesn't proof anything. If I/someone else did a mistake with
blacklisting would you say it is enough proof to request the inclusion
of well-known allowed characters?
> A black list is well-defined: it disables the display of certain
> characters because they are *known to be dangerous*.
What do you do with dangerous characters that are *not yet known* to be
dangerous?
> A white list on the other hand does it the wrong way around: it tries
> to put the 'burden of proof' on the useful, good guys - and that's
> counter-productive really.
Really? I think strict API definition is productive, unlike using it
in cases where it looks like working, but creating tricky and obscure
bugs.
Yes, drawing multicolor logs is funny, but ...egrrr... printk() is not
written for these things.
Thanks,
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
