Posted Jun 23, 2011 14:06 UTC (Thu) by proski (subscriber, #104)
Parent article: A hole in crypt_blowfish
That's the kind of code sparse should be able to find. Sparse can easily check if a boolean operation involves a sign-extended operand without a cast. I think it's almost always a bug. Using casts in the remaining cases would make the code more readable.