LWN.net Logo

Re: [PATCH 1/3] [RFC] genhd: add a new attribute in device structure

From:  Kay Sievers <kay.sievers-AT-vrfy.org>
To:  James Bottomley <James.Bottomley-AT-hansenpartnership.com>
Subject:  Re: [PATCH 1/3] [RFC] genhd: add a new attribute in device structure
Date:  Thu, 16 Jun 2011 19:20:07 +0200
Message-ID:  <BANLkTikUNqTxgD_+TTVpcFyRDu_fSesrsg@mail.gmail.com>
Cc:  Greg KH <greg-AT-kroah.com>, Nao Nishijima <nao.nishijima.xt-AT-hitachi.com>, linux-scsi-AT-vger.kernel.org, linux-kernel-AT-vger.kernel.org, jcm-AT-redhat.com, hare-AT-suse.de, stefanr-AT-s5r6.in-berlin.de, yrl.pp-manager.tt-AT-hitachi.com
Archive-link:  Article, Thread

On Thu, Jun 16, 2011 at 19:09, Kay Sievers <kay.sievers@vrfy.org> wrote:
> On Thu, Jun 16, 2011 at 18:25, James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
>> On Thu, 2011-06-16 at 09:14 -0700, Greg KH wrote:
>> > All userspace naming will be taken care of by the usual udev rules, so
>>> > for disks, something like /dev/disk/by-preferred/<fred> which would be
>>> > the usual symbolic link.
>>>
>>> No, udev can not create such a link after the preferred name is set, as
>>> it has no way of knowing that the name was set.
>>
>> It can if we trigger a uevent.  Note: I'm not advocating this ... I'd be
>> equally happy having whatever sets the kernel name create the link (or
>> tickle udev to create it).  We definitely require device links, though,
>> to get this to work.

Guess all that would work now, including mount(8) not canonicalizing.
What would happen if we mount:
  /dev/disk/by-pretty/foo
and some tool later thinks the pretty name should better be 'bar', it
writes the name to /sys, we get a uevent, the old link disappears, we
get a new link, mount has no device node anymore for the mounted
device ...

So we basically get a one-shot additional pretty name? Guess, the
_single_ name changed anytime later just asks for serious problems. We
need to set it very early to be really useful, but how, where is it
coming from?

Kay


(Log in to post comments)

Copyright © 2011, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds