Re: [PATCH] changegroup: do not prompt to merge after adding only closed heads (issue2697)

On Thu, 2011-04-14 at 22:40 +0200, Adrian Buehlmann wrote:
> On 2011-04-14 22:20, Matt Mackall wrote:
> > On Thu, 2011-04-14 at 22:01 +0200, Adrian Buehlmann wrote:
> >> On 2011-04-14 21:09, Kevin Gessner wrote:
> >>> When adding a changegroup adds N heads, M of which are closed, tell
> >>> the user that "(+N heads, M closed)" were added to the repository.
> >>
> >> "When adding a changegroup adds N heads, .."
> >>
> >> has still the same grammar bug, I'd say.
> > 
> > Parses here. "When [action] adds N heads".
> 
> Ok. But at least it's hard to read.
> 
> We shouldn't write law text.
> 
> > But I also should remark that grammar/spelling issues in commit message
> > bodies are way down on my list of priorities.
> 
> I personally have made the observation that if there's even an error or
> a bad description for the change, then the probability of a bug/flaw in
> the actual code change is indeed higher.
> 
> I can dig out actual evidence for that, if you like.
> 
> Call it "change message smell". It works quite well as an indicator.

On the other hand, we don't really want to require all our contributors
to have perfect English. Some of them are Americans, after all.

-- 
Mathematics is the supreme nostalgia of our time.