Re: [PATCH v2 2.6.38-rc8-tip 3/20] 3: uprobes: Breakground page
replacement.
[Posted March 16, 2011 by corbet]
| From: |
| Steven Rostedt <rostedt-AT-goodmis.org> |
| To: |
| Srikar Dronamraju <srikar-AT-linux.vnet.ibm.com> |
| Subject: |
| Re: [PATCH v2 2.6.38-rc8-tip 3/20] 3: uprobes: Breakground page
replacement. |
| Date: |
| Mon, 14 Mar 2011 14:22:42 -0400 |
| Message-ID: |
| <1300126962.9910.128.camel@gandalf.stny.rr.com> |
| Cc: |
| Peter Zijlstra <peterz-AT-infradead.org>, Ingo Molnar <mingo-AT-elte.hu>,
Linux-mm <linux-mm-AT-kvack.org>, Arnaldo Carvalho de Melo
<acme-AT-infradead.org>, Linus Torvalds <torvalds-AT-linux-foundation.org>,
Ananth N Mavinakayanahalli <ananth-AT-in.ibm.com>, Christoph Hellwig
<hch-AT-infradead.org>, Andi Kleen <andi-AT-firstfloor.org>, Masami Hiramatsu
<masami.hiramatsu.pt-AT-hitachi.com>, Oleg Nesterov <oleg-AT-redhat.com>, LKML
<linux-kernel-AT-vger.kernel.org>, Jim Keniston <jkenisto-AT-linux.vnet.ibm.com>,
Roland McGrath <roland-AT-hack.frob.com>, SystemTap
<systemtap-AT-sources.redhat.com>, Andrew Morton <akpm-AT-linux-foundation.org>,
"Paul E. McKenney" <paulmck-AT-linux.vnet.ibm.com> |
| Archive‑link: | |
Article |
On Mon, 2011-03-14 at 22:54 +0530, Srikar Dronamraju wrote:
> >
> > I'm confused by the above comment and code. You state we are only
> > interested text pages mapped read-only, but then if the page is mapped
> > read/exec we exit out? It is fine if it is anything but READ/EXEC.
>
> You are right, it should have been
> if ((vma->vm_flags & (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)) !=
> (VM_READ|VM_EXEC))
> goto put_out;
>
>
Golden rule #12: When the comments do not match the code, they probably
are both wrong ;)
-- Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
