Re: [PATCH 2/2] debugfs: only allow root access to debugging interfaces [LWN.net]

From:		Greg KH <gregkh-AT-suse.de>
To:		Kees Cook <kees.cook-AT-canonical.com>
Subject:		Re: [PATCH 2/2] debugfs: only allow root access to debugging interfaces
Date:		Tue, 22 Feb 2011 12:16:10 -0800
Message-ID:		<20110222201610.GA29787@suse.de>
Cc:		Alan Cox <alan-AT-lxorguk.ukuu.org.uk>, David Daney <ddaney-AT-caviumnetworks.com>, linux-kernel-AT-vger.kernel.org, Eugene Teo <eugeneteo-AT-kernel.sg>, Ralph Campbell <infinipath-AT-qlogic.com>, Roland Dreier <roland-AT-kernel.org>, Sean Hefty <sean.hefty-AT-intel.com>, Hal Rosenstock <hal.rosenstock-AT-gmail.com>, Jeremy Fitzhardinge <jeremy.fitzhardinge-AT-citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk-AT-oracle.com>, Alexander Viro <viro-AT-zeniv.linux.org.uk>, Miklos Szeredi <miklos-AT-szeredi.hu>, "J. Bruce Fields" <bfields-AT-fieldses.org>, Neil Brown <neilb-AT-suse.de>, Matthew Wilcox <matthew-AT-wil.cx>, James Morris <jmorris-AT-namei.org>, Stephen Smalley <sds-AT-tycho.nsa.gov>, Eric Paris <eparis-AT-parisplace.org>, Nick Piggin <npiggin-AT-kernel.dk>, Arnd Bergmann <arnd-AT-arndb.de>, Ian Campbell <ian.campbell-AT-citrix.com>, Jarkko Sakkinen <ext-jarkko.2.sakkinen-AT-nokia.com>, Tejun Heo <tj-AT-kernel.org>, Casey Sch
Archive-link:		Article, Thread

On Tue, Feb 22, 2011 at 11:50:18AM -0800, Kees Cook wrote:
> On Tue, Feb 22, 2011 at 07:34:18PM +0000, Alan Cox wrote:
> > > What system do you proposed to keep these "stupid mistakes" from
> > > continuing to happen? If debugfs had already been mode 0700, we could have
> > > avoided all of these CVEs, including the full-blown local root escalation.
> > 
> > And all sorts of features would have put themselves in sysfs instead and
> > broken no doubt.
> > 
> > > The "no rules" approach to debugfs is not a good idea, IMO.
> > 
> > It's a debugging fs, it needs to be "no rules" other than the obvious
> > "don't mount it on production systems"
> 
> Okay, so the debugfs is not supposed to be mounted on a production system.

No, not true at all, the "enterprise" distros all mount debugfs for good
reason on their systems.

> This seems to be news to a lot of developers trying to use the interfaces
> exposed there. It would be nice to say this more loudly.  Basically,
> a normal system should not depend on anything in the debugfs. I can get
> behind that.

Again, not true.  Mostly all due to the perf interface, fix that to move
out of debugfs (patches have been proposed) and this problem will go
away.

thanks,

greg k-h

(Log in to post comments)