LWN.net Logo

Tarsnap advisory provides a few lessons

Tarsnap advisory provides a few lessons

Posted Jan 20, 2011 7:02 UTC (Thu) by ion (subscriber, #58683)
Parent article: Tarsnap advisory provides a few lessons

I’d also point out that having subtle side-effects within function call parameters might be something to be avoided. Had ‘encr_aes->nonce++’ been a separate expression it might have been less likely to be forgotten when refactoring.


(Log in to post comments)

Copyright © 2013, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds