LWN.net Logo

Re: [RFC][PATCH 0/2] tracing: Have trace_printk()s in the events/ directory

From:  Peter Zijlstra <peterz-AT-infradead.org>
To:  Steven Rostedt <rostedt-AT-goodmis.org>
Subject:  Re: [RFC][PATCH 0/2] tracing: Have trace_printk()s in the events/ directory
Date:  Thu, 18 Nov 2010 11:41:06 +0100
Message-ID:  <1290076866.2109.1305.camel@laptop>
Cc:  linux-kernel-AT-vger.kernel.org, Ingo Molnar <mingo-AT-elte.hu>, Andrew Morton <akpm-AT-linux-foundation.org>, Thomas Gleixner <tglx-AT-linutronix.de>, Frederic Weisbecker <fweisbec-AT-gmail.com>, Darren Hart <dvhart-AT-linux.intel.com>, Linus Torvalds <torvalds-AT-linux-foundation.org>, "jason.wessel" <jason.wessel-AT-windriver.com>, Ted Ts'o <tytso-AT-mit.edu>, Mathieu Desnoyers <mathieu.desnoyers-AT-efficios.com>
Archive-link:  Article, Thread

On Wed, 2010-11-17 at 22:58 -0500, Steven Rostedt wrote:
> For example, I added a trace_printk() in kernel/sched.c at line 2180
> and it creates:
> 
> # ls /debug/tracing/events/printk/kernel/sched.c/2180/
> enable  format
> 
> The format is the printk format:
> 
> # cat /debug/tracing/events/printk/kernel/sched.c/2180/format 
> "migrate task %s:%d"

*groan*, so you're creating a tracepoint per instance?

That's going to be massive pain for perf.. I really don't see the point
in splitting all that out.


(Log in to post comments)

Copyright © 2010, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds