As a general rule, if a reviewer's comment doesn't result in a code
change then it should result in a changelog fix or a code comment.
Because if the code wasn't clear enough to the reviewer then it
won't be clear enough to later readers.
-- Andrew Morton
AMD's reference BIOS code had a bug that could result in the
firmware failing to reenable the iommu on resume. It transpires
that this causes certain less than desirable behaviour when it
comes to PCI accesses, to whit them ending up somewhere near
Bristol when the more desirable outcome was Edinburgh. Sadness
ensues, perhaps along with filesystem corruption. Let's make sure
that it gets turned back on, and that we restore its configuration
so decisions it makes bear some resemblance to those made by
reasonable people rather than crack-addled lemurs who spent all
your DMA on Thunderbird.
-- Matthew Garrett
to post comments)