LWN.net Logo

Re: [PATCH] tty: avoid recursive BTM in pty_close

From:  Alan Cox <alan-AT-lxorguk.ukuu.org.uk>
To:  Arnd Bergmann <arnd-AT-arndb.de>
Subject:  Re: [PATCH] tty: avoid recursive BTM in pty_close
Date:  Fri, 18 Jun 2010 17:21:21 +0100
Cc:  Frederic Weisbecker <fweisbec-AT-gmail.com>, Tony Luck <tony.luck-AT-intel.com>, linux-kernel-AT-vger.kernel.org, Greg KH <gregkh-AT-suse.de>, Thomas Gleixner <tglx-AT-linutronix.de>, Andrew Morton <akpm-AT-linux-foundation.org>, John Kacur <jkacur-AT-redhat.com>, Al Viro <viro-AT-zeniv.linux.org.uk>, Ingo Molnar <mingo-AT-elte.hu>
Archive-link:  Article, Thread

> I'd like to get Alan's opinion on whether he considers the change in
> pty.c safe.

I considered it a while ago when trying to work out removing the BKL from
this path. After much head banging and an overwhelming desire to go and
get drunk instead I concluded it wasn't possible to tell by analysis.

So I ack this patch - it's the only way to find out 8)

Alan


(Log in to post comments)

Copyright © 2010, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds