Re: [PATCH] vfs: Fix O_NOFOLLOW behavior for paths with trailing slashes [LWN.net]

From:		Andrew Morton <akpm-AT-linux-foundation.org>
To:		Jan Kara <jack-AT-suse.cz>
Subject:		Re: [PATCH] vfs: Fix O_NOFOLLOW behavior for paths with trailing slashes
Date:		Thu, 13 May 2010 08:43:35 -0400
Cc:		Linus Torvalds <torvalds-AT-linux-foundation.org>, LKML <linux-kernel-AT-vger.kernel.org>, linux-fsdevel-AT-vger.kernel.org, stable-AT-kernel.org, Al Viro <viro-AT-zeniv.linux.org.uk>
Archive-link:		Article, Thread

On Thu, 13 May 2010 17:41:35 +0200 Jan Kara <jack@suse.cz> wrote:

> On Thu 13-05-10 08:24:59, Linus Torvalds wrote:
> > 
> > 
> > On Thu, 13 May 2010, Jan Kara wrote:
> > >
> > > According to specification
> > > mkdir d; ln -s d a; open("a/", O_NOFOLLOW | O_RDONLY)
> > > should return success but currently it did return ELOOP. Fix the code to ignore
> > > O_NOFOLLOW in case the provided path has trailing slashes. This is a regression
> > > caused by path lookup cleanup patch series.
> > > 
> > > CC: stable@kernel.org
> > 
> > Hmm? Is this correct? Isn't the bug introduced in this merge window, and 
> > thus not relevant for stable?
>   Ah, you're right! I've seen dates in the patches around December so I
> automatically thought the series went to 2.6.33 but checking git logs and
> the actual source code of 2.6.33 it went in later. I'm sorry for the
> confusion.

Yes, it's a bit tricky (for me, at least) to work out "which kernel version did
that patch go into" via git.

I just keep lots of kernel trees around and poke about with `patch
--dry-run'.  PITA.

(Log in to post comments)