LWN.net Logo

Re: [linux-pm] suspend blockers & Android integration

From:  Linus Torvalds <torvalds-AT-linux-foundation.org>
To:  david-AT-lang.hm
Subject:  Re: [linux-pm] suspend blockers & Android integration
Date:  Tue, 8 Jun 2010 20:46:20 -0700 (PDT)
Message-ID:  <alpine.LFD.2.00.1006082042020.4506@i5.linux-foundation.org>
Cc:  Florian Mickler <florian-AT-mickler.org>, Vitaly Wool <vitalywool-AT-gmail.com>, Brian Swetland <swetland-AT-google.com>, =?ISO-8859-15?Q?Arve_Hj=F8nnev=E5g?= <arve-AT-android.com>, Arjan van de Ven <arjan-AT-infradead.org>, tytso-AT-mit.edu, Peter Zijlstra <peterz-AT-infradead.org>, "H. Peter Anvin" <hpa-AT-zytor.com>, LKML <linux-kernel-AT-vger.kernel.org>, Neil Brown <neilb-AT-suse.de>, James Bottomley <James.Bottomley-AT-suse.de>, Alan Cox <alan-AT-lxorguk.ukuu.org.uk>, Linux PM <linux-pm-AT-lists.linux-foundation.org>, Ingo Molnar <mingo-AT-elte.hu>, Linux OMAP Mailing List <linux-omap-AT-vger.kernel.org>, Thomas Gleixner <tglx-AT-linutronix.de>, Felipe Balbi <felipe.balbi-AT-nokia.com>
Archive-link:  Article, Thread



On Tue, 8 Jun 2010, david@lang.hm wrote:
> 
> having suspend blockers inside the kernel adds significant complexity, it's
> worth it only if the complexity buys you enough. In this case the question is
> if the suspend blockers would extend the sleep time enough more to matter. As
> per my other e-mail, this is an area with rapidly diminishing returns as the
> sleep times get longer.

Well, the counter-argument that nobody seems to have brought up is that 
suspend blockers exist, are real code, and end up being shipped in a lot 
of machines.

That's a _big_ argument in favour of them. Certainly much bigger than 
arguing against them based on some complexity-arguments for an alternative 
that hasn't seen any testing at all.

IOW, I would seriously hope that this discussion was more about real code 
that _exists_ and does what people need. It seems to have degenerated into 
something else.

Because in the end, "code talks, bullshit walks". People can complain and 
suggest alternatives all they want, but you can't just argue. At some 
point you need to show the code that actually solves the problem.

				Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


(Log in to post comments)

Copyright © 2010, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds