LWN.net Logo

Re: [PATCH] x86: Export tsc related information in sysfs

From:  Andi Kleen <andi-AT-firstfloor.org>
To:  Venkatesh Pallipadi <venki-AT-google.com>
Subject:  Re: [PATCH] x86: Export tsc related information in sysfs
Date:  Sat, 15 May 2010 11:57:04 +0200
Cc:  Ingo Molnar <mingo-AT-elte.hu>, Thomas Gleixner <tglx-AT-linutronix.de>, "H. Peter Anvin" <hpa-AT-zytor.com>, Chris Mason <chris.mason-AT-oracle.com>, linux-kernel-AT-vger.kernel.org, Dan Magenheimer <dan.magenheimer-AT-oracle.com>
Archive-link:  Article, Thread

Venkatesh Pallipadi <venki@google.com> writes:

> From: Dan Magenheimer <dan.magenheimer@oracle.com>
>
> Kernel information about calibrated value of tsc_khz and
> tsc_stability (result of tsc warp test) are useful bits of information
> for any app that wants to use TSC directly. Export this read_only
> information in sysfs.

Is this really a good idea?  It will encourage the applications
to use RDTSC directly, but there are all kinds of constraints on
that. Even the kernel has a hard time with them, how likely
is it that applications will get all that right?

It would be better to fix them to use the vsyscalls instead.
Or if they can't use the vsyscalls for some reason today fix them.

This way if anything changes again in TSC the kernel could
shield the applications. 

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.


(Log in to post comments)

Copyright © 2010, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds