Re: [PATCH 0/8] Suspend block api (version 6) [LWN.net]

From:		Matthew Garrett <mjg-AT-redhat.com>
To:		Tony Lindgren <tony-AT-atomide.com>
Subject:		Re: [PATCH 0/8] Suspend block api (version 6)
Date:		Tue, 11 May 2010 18:30:36 +0100
Cc:		"Rafael J. Wysocki" <rjw-AT-sisk.pl>, Kevin Hilman <khilman-AT-deeprootsystems.com>, Arve HjÃ¸nnevÃ¥g <arve-AT-android.com>, linux-pm-AT-lists.linux-foundation.org, linux-kernel-AT-vger.kernel.org, Alan Stern <stern-AT-rowland.harvard.edu>, Tejun Heo <tj-AT-kernel.org>, Oleg Nesterov <oleg-AT-redhat.com>, Paul Walmsley <paul-AT-pwsan.com>, magnus.damm-AT-gmail.com, mark gross <mgross-AT-linux.intel.com>, Arjan van de Ven <arjan-AT-infradead.org>, Geoff Smith <geoffx.smith-AT-intel.com>, Brian Swetland <swetland-AT-google.com>
Archive-link:		Article, Thread

On Tue, May 11, 2010 at 10:24:43AM -0700, Tony Lindgren wrote:

> For the failed suspend path in the kernel, currently the kernel would
> unwind back all the drivers because of the failed driver, but that path
> should be possible to optimize.

If you think it's possible to make this work then feel free to. But at 
the point where you're adding code to every driver's suspend function to 
determine whether or not it's got any pending events that userspace 
hasn't consumed yet, and adding code to every bit of userspace to allow 
it to indicate whether or not it's busy consuming events or just busy 
drawing 3D bouncing cattle, I think you've reinvented suspend blocks.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

(Log in to post comments)