Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon

From:		Borislav Petkov <bp-AT-alien8.de>
To:		Linus Torvalds <torvalds-AT-linux-foundation.org>
Subject:		Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA
Date:		Mon, 12 Apr 2010 23:50:27 +0200
Cc:		Johannes Weiner <hannes-AT-cmpxchg.org>, KOSAKI Motohiro <kosaki.motohiro-AT-jp.fujitsu.com>, Rik van Riel <riel-AT-redhat.com>, Andrew Morton <akpm-AT-linux-foundation.org>, Minchan Kim <minchan.kim-AT-gmail.com>, Linux Kernel Mailing List <linux-kernel-AT-vger.kernel.org>, Lee Schermerhorn <Lee.Schermerhorn-AT-hp.com>, Nick Piggin <npiggin-AT-suse.de>, Andrea Arcangeli <aarcange-AT-redhat.com>, Hugh Dickins <hugh.dickins-AT-tiscali.co.uk>, sgunderson-AT-bigfoot.com
Archive-link:		Article, Thread

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon, Apr 12, 2010 at 09:26:57AM -0700

> I have a new theory. And this new theory is completely different from all 
> the other things we've been looking at.

Yeah, because all starts with "I have a new theory..." :o)

> The patch below is my largely mindless try at fixing this. It's untested. 
> I'm not entirely sure that it actually works. But it makes some amount of 
> conceptual sense. No?

Linus, are you trying to give me a heart-attack? This sh*t just survived
20(!) hibernation runs without a problem (well, there is this nagging
/sysfs lockdep warning) but apart from that, it survived! I even did my
all time best when hitting on it. Normally, it used to crap up on the
6th cycle as latest. Now we're rock solid. And yes, there were something
like ~64Mb in the swap cache.

Also, I have your verification stuff in addition to the 4 patches you
sent before. Not a single WARN_ONCE got triggered. So I have a gut
feeling that it is fixed but you never know with these beasts.

As before, I'll rebuild and reapply everything in the morning and retest
just in case. And I guess I'll have to test all following -rc's so that
we can be absolutely sure.

So cheers!

-- 
Regards/Gruss,
    Boris.

(Log in to post comments)

Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA