LWN.net Logo

Re: [PATCH 00 of 41] Transparent Hugepage Support #17

From:  Andrew Morton <akpm-AT-linux-foundation.org>
To:  Andrea Arcangeli <aarcange-AT-redhat.com>
Subject:  Re: [PATCH 00 of 41] Transparent Hugepage Support #17
Date:  Mon, 5 Apr 2010 12:09:06 -0700
Cc:  linux-mm-AT-kvack.org, Marcelo Tosatti <mtosatti-AT-redhat.com>, Adam Litke <agl-AT-us.ibm.com>, Avi Kivity <avi-AT-redhat.com>, Izik Eidus <ieidus-AT-redhat.com>, Hugh Dickins <hugh.dickins-AT-tiscali.co.uk>, Nick Piggin <npiggin-AT-suse.de>, Rik van Riel <riel-AT-redhat.com>, Mel Gorman <mel-AT-csn.ul.ie>, Dave Hansen <dave-AT-linux.vnet.ibm.com>, Benjamin Herrenschmidt <benh-AT-kernel.crashing.org>, Ingo Molnar <mingo-AT-elte.hu>, Mike Travis <travis-AT-sgi.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu-AT-jp.fujitsu.com>, Christoph Lameter <cl-AT-linux-foundation.org>, Chris Wright <chrisw-AT-sous-sol.org>, bpicco-AT-redhat.com, KOSAKI Motohiro <kosaki.motohiro-AT-jp.fujitsu.com>, Balbir Singh <balbir-AT-linux.vnet.ibm.com>, Arnd Bergmann <arnd-AT-arndb.de>, "Michael S. Tsirkin" <mst-AT-redhat.com>, Peter Zijlstra <peterz-AT-infra
Archive-link:  Article, Thread


Problem.  It appears that these patches have only been sent to
linux-mm.  Linus doesn't read linux-mm and has never seen them.  I do
think we should get things squared away with him regarding the overall
intent and implementation approach before trying to go further.

I forwarded "[PATCH 27 of 41] transparent hugepage core" and his
summary was "So I don't hate the patch, but it sure as hell doesn't
make me happy either.  And if the only advantage is about TLB miss
costs, I really don't see the point personally.".  So if there's more
benefit to the patches than this, that will need some expounding upon.

So I'd suggest that you a) address some minor Linus comments which I'll
forward separately, b) rework [patch 0/n] to provide a complete
description of the benefits and the downsides (if that isn't there
already) and c) resend everything, cc'ing Linus and linux-kernel and
we'll get it thrashed out.


Sorry.  Normally I use my own judgement on MM patches, but in this case
if I was asked "why did you send all this stuff", I don't believe I
personally have strong enough arguments to justify the changes - you're
in a better position than I to make that case.  Plus this is a *large*
patchset, and it plays in an area where Linus is known to have, err,
opinions.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>



(Log in to post comments)

Copyright © 2010, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds