[61/93] SCSI: mptfusion : mptscsih_abort return value should be SUCCESS instead of value 0. [LWN.net]

From:		Greg KH <gregkh-AT-suse.de>
To:		linux-kernel-AT-vger.kernel.org, stable-AT-kernel.org
Subject:		[61/93] SCSI: mptfusion : mptscsih_abort return value should be SUCCESS instead of value 0.
Date:		Fri, 19 Feb 2010 08:29:54 -0800
Cc:		stable-review-AT-kernel.org, torvalds-AT-linux-foundation.org, akpm-AT-linux-foundation.org, alan-AT-lxorguk.ukuu.org.uk, Kashyap Desai <kashyap.desai-AT-lsi.com>, James Bottomley <James.Bottomley-AT-suse.de>
Archive-link:		Article, Thread

2.6.32-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Kashyap, Desai <kashyap.desai@lsi.com>

commit 9858ae38011d699d4c2fa7f3493a47accf43a0f5 upstream.

retval should be SUCCESS/FAILED which is defined at scsi.h
retval = 0 is directing wrong return value. It must be retval = SUCCESS.

Signed-off-by: Kashyap Desai <kashyap.desai@lsi.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/message/fusion/mptscsih.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/message/fusion/mptscsih.c
+++ b/drivers/message/fusion/mptscsih.c
@@ -1720,7 +1720,7 @@ mptscsih_abort(struct scsi_cmnd * SCpnt)
 		dtmprintk(ioc, printk(MYIOC_s_DEBUG_FMT "task abort: "
 		   "Command not in the active list! (sc=%p)\n", ioc->name,
 		   SCpnt));
-		retval = 0;
+		retval = SUCCESS;
 		goto out;
 	}

(Log in to post comments)