| From: |
| Andi Kleen <andi@firstfloor.org> |
| To: |
| ebiederm@xmission.com, paulmck@linux.vnet.ibm.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org |
| Subject: |
| [PATCH] [0/9] SYSCTL: Use RCU to avoid races with string sysctls v2 |
| Date: |
| Tue, 5 Jan 2010 03:15:25 +0100 (CET) |
| Message-ID: |
| <20100105315.789846878@firstfloor.org> |
| Archive-link: |
| Article, Thread
|
v2 version that addresses all the earlier review comments
minus patches that were already merged.
I think this one is ready for merge now. Andrew, could you please
take it?
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
With BKL-less sysctls most of the writable string sysctls are racy. There
is no locking on the reader side, so a reader could see an inconsistent
string or worse miss the terminating null and walk of beyond it.
This patch kit adds a new "rcu string" variant to avoid these
problems and convers the racy users. One the writer side the strings are
always copied to new memory and the readers use rcu_read_lock()
to get a stable view. For readers who access the string over
sleeps the reader copies the string.
This is all hidden in a new generic "rcu_string" ADT which can be also
used for other purposes.
This finally implements all the letters in RCU, most other users
leave out the 'C'.
I left some obscure users in architectures (sparc, mips) alone and audited
all of the others. The sparc reboot_cmd one has references to asm files
which I didn't want to touch and the mips variant seemd just too obscure.
All the others are not racy.
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/