LWN.net Logo

pr_unwanted()?

pr_unwanted()?

Posted Dec 24, 2009 8:53 UTC (Thu) by flewellyn (subscriber, #5047)
Parent article: pr_unwanted()?

I think their real purpose was actually best expressed by Al Viro:

"leveraging the synergy between make-work job and commit count masturbation"


(Log in to post comments)

pr_unwanted()?

Posted Dec 24, 2009 9:21 UTC (Thu) by liljencrantz (guest, #28458) [Link]

Less typing and more explicit code sounds like two very reasonable reasons to use a bit of code to me.

pr_unwanted()?

Posted Dec 24, 2009 16:31 UTC (Thu) by grmd (subscriber, #4391) [Link]

The trouble is it's the thin end of the wedge; it's not any more specific,
and it means that developers needlessly have something extra to learn.

Having worked on project that layer macros upon macros it rapidly becomes a
nightmare to maintain despite the original good intentions, turning C into a
write-once language.

pr_unwanted()?

Posted Dec 24, 2009 19:14 UTC (Thu) by vonbrand (subscriber, #4458) [Link]

"More explicit" as long as there are very few functions/macros around. If there are more than a dozen, you start wondering if what you think it does is right... and the kernel is already huge, with its own set of non-standard stuff and rules.

Better leave them out.

Copyright © 2013, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds