Weekly edition	Kernel	Security	Distributions	Contact Us	Search
Archives	Calendar	Subscribe	Write for LWN	LWN.net FAQ	Sponsors

Good tool, but a bug treadmill

Posted Nov 3, 2009 17:15 UTC (Tue) by bgilbert (subscriber, #4738)
Parent article: Gerrit: Google-style code review meets git

Gerrit is a nice tool, but it's also a bit of a bug treadmill. My bug reports have always been addressed before the next release (and releases are frequent), but you never know what new problems are going to ship alongside the fixes.

I've taken to running the SQL schema upgrade scripts statement-by-statement using copy-and-paste. The last three or four (in official releases, mind!) have contained syntax errors.

(Log in to post comments)

Posted Nov 3, 2009 21:27 UTC (Tue) by sxw (guest, #61770) [Link]

That might be true of the MySQL scripts, but I've never had a problem with the postgres ones. I
made the decision when setting up OpenAFS's gerrit instance to keep our setup as close to the one
that upstream targets in order to avoid exactly these problems.

Good tool, but a bug treadmill

Posted Nov 9, 2009 14:54 UTC (Mon) by spearce (guest, #61702) [Link]

Your comment about the MySQL upgrade scripts is on the mark.

I'm not a fan of MySQL and avoid using it whenever possible. The only
reason Gerrit even runs on it is because a few people whined, and I figured
adding the support if they helped maintain it would be easier than telling
them "go install PostgreSQL". Unfortunately the MySQL using crowd doesn't
get around to testing the upgrade scripts until after I've cut a release.

We should start to be improving in the MySQL compatibility area. I'm
unfortunately running a production Gerrit on a MySQL backend now, which
means I now have more personal incentive to validate the upgrade scripts
are syntactically correct.