LWN.net Logo

Re: [PATCH 3/5] checkpatch: add a blacklist

From:  Alan Cox <alan-AT-lxorguk.ukuu.org.uk>
To:  Daniel Walker <dwalker-AT-fifo99.com>
Subject:  Re: [PATCH 3/5] checkpatch: add a blacklist
Date:  Wed, 7 Oct 2009 16:11:07 +0100
Cc:  Krzysztof Halasa <khc-AT-pm.waw.pl>, Andy Whitcroft <apw-AT-canonical.com>, Li Zefan <lizf-AT-cn.fujitsu.com>, Andrew Morton <akpm-AT-linux-foundation.org>, linux-kernel-AT-vger.kernel.org, Steven Rostedt <rostedt-AT-goodmis.org>
Archive-link:  Article, Thread

> Right it's a tool .. However, you should use it and you should follow
> it. If for some reason you disagree with the tool you have to give at
> least an arguable reason why, not just "It's a guide", "I don't like the
> coding style." etc..

Those are perfectly good reasons.

> In the case of Steven's code he has an arguable reason why he's not
> following checkpatch..

Checkpatch is not very bright, it has no understanding of style beyond
playing with pattern regexps. It's a rather dim tool that helps people
get work done. (*)

When used at random to "validate" submissions to the kernel the result is
about as useful as a square wheel on a hovercraft.

Alan
(*) or as some would have it a rather dim tool used by even dimmer tools
to make noise on kernel list.


(Log in to post comments)

Copyright © 2009, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds