LWN.net Logo

Re: [PATCH 2/7] kfifo: move out spinlock

From:  Alan Cox <alan-AT-lxorguk.ukuu.org.uk>
To:  Stefani Seibold <stefani-AT-seibold.net>
Subject:  Re: [PATCH 2/7] kfifo: move out spinlock
Date:  Sun, 16 Aug 2009 23:58:43 +0100
Message-ID:  <20090816235843.0f7f11de@lxorguk.ukuu.org.uk>
Cc:  linux-kernel <linux-kernel-AT-vger.kernel.org>, Andrew Morton <akpm-AT-linux-foundation.org>, Arnd Bergmann <arnd-AT-arndb.de>, Andi Kleen <andi-AT-firstfloor.org>, Amerigo Wang <xiyou.wangcong-AT-gmail.com>, Joe Perches <joe-AT-perches.com>
Archive-link:  Article, Thread

On Sun, 16 Aug 2009 22:46:30 +0200
Stefani Seibold <stefani@seibold.net> wrote:

> Move the pointer to the spinlock out of struct kfifo. Most
> users in tree do not actually use a spinlock, so the few
> exceptions now have to call kfifo_{get,put}_locked, which takes
> an extra argument to a spinlock.

NAK this one for the moment

We are about to set fifo loose through all the USB and some other
char/serial drivers all of which will use the spinlock facility.


(Log in to post comments)

Copyright © 2009, Eklektix, Inc.
Comments and public postings are copyrighted by their creators.
Linux is a registered trademark of Linus Torvalds