|| ||Heiko Carstens <email@example.com> |
|| ||Ingo Molnar <firstname.lastname@example.org>, email@example.com |
|| ||[Patch/RFC 0/4] Allow inlined spinlocks (again) |
|| ||Mon, 10 Aug 2009 10:13:24 +0200|
|| ||Horst Hartmann <firstname.lastname@example.org>,
Christian Ehrhardt <email@example.com>,
Martin Schwidefsky <firstname.lastname@example.org>|
|| ||Article, Thread
This patch set allows to have inlined spinlocks (again).
The rationale behind this is that function calls on at least s390 are
If one considers that server kernels are usually compiled with
!CONFIG_PREEMPT a simple spin_lock is just a compare and swap loop.
The extra overhead for a function call is significant.
With inlined spinlocks overall cpu usage gets reduced by 1%-5% on s390.
These numbers were taken with some network benchmarks. However I expect
any workload that calls frequently into the kernel and which grabs a few
spinlocks to perform better.
Please note: I'm aware that this implementation is a bit ;) ugly and
might also contain bugs. But the performance improvements show that its
worth to do something in this area.
The actual implemtation is quite simple: move the spinlock C code to
a header file and add some wrappers. Configuration dependent this
file gets included into a C file and normal spinlock functions like
we them currently will generated. Otherwise the inline variants
will be generated as we had them before the out of line code was
A standard spinlock function like this
void __lockfunc _spin_lock(spinlock_t *lock)
gets converted to
LOCKFUNC void _spin_lock(spinlock_t *lock)
where LOCKFUNC and SPIN_EXPORT_SYMBOL get expanded dependent
#define LOCKFUNC static inline
#else /* CONFIG_SPINLOCK_INLINE */
#define LOCKFUNC __lockfunc
#define SPIN_EXPORT_SYMBOL(func) EXPORT_SYMBOL(func)
#endif /* CONFIG_SPINLOCK_INLINE */
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to email@example.com
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/