|| ||Martin Schwidefsky <firstname.lastname@example.org> |
|| ||email@example.com |
|| ||[RFC][patch 00/12] clocksource / timekeeping rework V2 |
|| ||Wed, 29 Jul 2009 15:41:25 +0200|
|| ||Ingo Molnar <firstname.lastname@example.org>, Thomas Gleixner <email@example.com>,
john stultz <firstname.lastname@example.org>,
Daniel Walker <email@example.com>|
|| ||Article, Thread
version 2 of the clocksource / timekeeping cleanup patches. The series
has grown quite a bit, what started with a simple idea to replace the
tick based clocksource update with stop_machine is now a full fledged
The code is working on s390 and on my Athlon system at home which has
a broken tsc clocksource:
[ 0.000000] Fast TSC calibration using PIT
[ 0.000341] hpet clockevent registered
[ 0.000343] HPET: 3 timers in total, 0 timers will be used for per-cpu timer
[ 0.204021] hpet0: at MMIO 0xfefff000, IRQs 2, 8, 31
[ 0.204027] hpet0: 3 comparators, 32-bit 25.000000 MHz counter
[ 0.208007] Switching to clock hpet
[ 0.211544] Switched to high resolution mode on CPU 0
[ 0.211960] Switched to high resolution mode on CPU 1
[ 8.000020] Clocksource tsc unstable (delta = -172310085 ns)
So the clocksource switch via stop_machine and the clocksource watchdog
are working. I keep the fingers crossed that nothing else breaks.
The patch set is based on todays upstream tree plus the patches from
the tip tree, if anyone wants to try them you need to pull from the
master branch of
There is still more room for improvement. Some sore points are:
1) The cycle_last value still is in the struct clocksource. It should
be in the struct timekeeper but the check against cycles_last in the
read function of the TSC clock source makes it hard.
2) read_persistent_clock returns seconds. With a really good initial
time source this is not very precise. read_persistent_clock should
return a struct timespec.
3) xtime, raw_time, total_sleep_time, timekeeping_suspended, jiffies,
the ntp state and probably a few other values may be better located
in the struct timekeeper as well.
and a few more I forgot.
Many thanks to John who pushed me into the right directions.
"Reality continues to ruin my life." - Calvin.