Re: [PATCH] coredump: Retry writes where appropriate [LWN.net]

From:		Alan Cox <alan-AT-lxorguk.ukuu.org.uk>
To:		paul-AT-mad-scientist.net
Subject:		Re: [PATCH] coredump: Retry writes where appropriate
Date:		Sun, 31 May 2009 11:18:51 +0100
Message-ID:		<20090531111851.07eb1df3@lxorguk.ukuu.org.uk>
Cc:		linux-kernel-AT-vger.kernel.org, stable-AT-kernel.org, Andrew Morton <akpm-AT-linux-foundation.org>, Andi Kleen <andi-AT-firstfloor.org>, Oleg Nesterov <oleg-AT-redhat.com>, Roland McGrath <roland-AT-redhat.com>
Archive-link:		Article, Thread

On Sun, 31 May 2009 01:33:39 -0400
Paul Smith <paul@mad-scientist.net> wrote:

> coredump: Retry writes where appropriate
> 
> Core dump write operations (especially to a pipe) can be incomplete due
> to signal reception or possibly recoverable partial writes.

NAK this

> Previously any incomplete write in the ELF core dumper caused the core
> dump to stop, giving short cores in these cases.  Modify the core dumper
> to retry the write where appropriate.

The existing behaviour is an absolute godsend when you've something like
a core dump stuck on an NFS mount or something trying to core dump to
very slow media.

In fact the signals checks were *purposefully added* some time ago.

Alan

(Log in to post comments)